VariablePolicy support in StandaloneMM

VariablePolicy support in StandaloneMM

[Masahisa Kojima]

Hello All,

VariablePolicy was introduced in November.
When Developerbox(aarch64 platform) boots with UEFI secure boot enabled,
the following error appears.
Note that this platform supports UEFI secure boot using the standalone
MM framework.

--- StandaloneMM log ---
VariableLockRequestToLock - Failed to lock variable CapsuleMax! Not Ready

ASSERT_EFI_ERROR (Status = Not Ready)
ASSERT [VariableStandaloneMm]
/home/ubuntu/src/uefi/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.c(64):
!EFI_ERROR (Status)
MmEntryPoint Done
---

In my check, this is simply because
MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c::InitVariablePolicyLib()
is not called.

InitVariablePolicyLib() is called from the following two files.
---
  MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c:  Status
= InitVariablePolicyLib( VariableServiceGetVariable );
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c:  Status =
InitVariablePolicyLib (VariableServiceGetVariable);
---
VariableDxe.c is not for MM_STANDALONE, so I tried to use
"VarCheckPolicyLib" as VarCheckLib,
but "VarCheckPolicyLib" requires
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf and
DxeServicesLib.inf is not for MM_STANDALONE, I am stuck here.

Could you please take a look at this error?

Thanks,
Masahisa

Re: VariablePolicy support in StandaloneMM

[Ard Biesheuvel]

(+ Laszlo)

On 12/2/20 9:57 AM, Masahisa Kojima wrote:
> Hello All,
> 
> VariablePolicy was introduced in November.
> When Developerbox(aarch64 platform) boots with UEFI secure boot enabled,
> the following error appears.
> Note that this platform supports UEFI secure boot using the standalone
> MM framework.
> 
> --- StandaloneMM log ---
> VariableLockRequestToLock - Failed to lock variable CapsuleMax! Not Ready
> 
> ASSERT_EFI_ERROR (Status = Not Ready)
> ASSERT [VariableStandaloneMm]
> /home/ubuntu/src/uefi/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequestToLock.c(64):
> !EFI_ERROR (Status)
> MmEntryPoint Done
> ---
> 
> In my check, this is simply because
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c::InitVariablePolicyLib()
> is not called.
> 
> InitVariablePolicyLib() is called from the following two files.
> ---
>   MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c:  Status
> = InitVariablePolicyLib( VariableServiceGetVariable );
>   MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c:  Status =
> InitVariablePolicyLib (VariableServiceGetVariable);
> ---
> VariableDxe.c is not for MM_STANDALONE, so I tried to use
> "VarCheckPolicyLib" as VarCheckLib,
> but "VarCheckPolicyLib" requires
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf and
> DxeServicesLib.inf is not for MM_STANDALONE, I am stuck here.
> 
> Could you please take a look at this error?
> 

Thanks for the report.

Bret, could you please suggest a fix here?

回复: VariablePolicy support in StandaloneMM

[gaoliming]

I just quick check. VarCheckPolicyLib doesn't consume DxeServicesLib. But, VarCheckPolicyLib library doesn't StandaloneMM type. 

So, I think StandaloneMM version VarCheckPolicyLib is required. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 发送时间: 2020年12月2日 17:02
> 收件人: Masahisa Kojima <masahisa.kojima@linaro.org>;
> edk2-devel-groups-io <devel@edk2.groups.io>
> 抄送: Bret.Barkelew@microsoft.com; jian.j.wang@intel.com;
> hao.a.wu@intel.com; gaoliming@byosoft.com.cn; Sami Mujawar
> <sami.mujawar@arm.com>; jiewen.yao@intel.com; Laszlo Ersek
> <lersek@redhat.com>
> 主题: Re: VariablePolicy support in StandaloneMM
> 
> (+ Laszlo)
> 
> On 12/2/20 9:57 AM, Masahisa Kojima wrote:
> > Hello All,
> >
> > VariablePolicy was introduced in November.
> > When Developerbox(aarch64 platform) boots with UEFI secure boot
> enabled,
> > the following error appears.
> > Note that this platform supports UEFI secure boot using the standalone
> > MM framework.
> >
> > --- StandaloneMM log ---
> > VariableLockRequestToLock - Failed to lock variable CapsuleMax! Not Ready
> >
> > ASSERT_EFI_ERROR (Status = Not Ready)
> > ASSERT [VariableStandaloneMm]
> >
> /home/ubuntu/src/uefi/edk2/MdeModulePkg/Universal/Variable/RuntimeDx
> e/VariableLockRequestToLock.c(64):
> > !EFI_ERROR (Status)
> > MmEntryPoint Done
> > ---
> >
> > In my check, this is simply because
> >
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c::InitVariablePoli
> cyLib()
> > is not called.
> >
> > InitVariablePolicyLib() is called from the following two files.
> > ---
> >   MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c:
> Status
> > = InitVariablePolicyLib( VariableServiceGetVariable );
> >   MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c:  Status
> =
> > InitVariablePolicyLib (VariableServiceGetVariable);
> > ---
> > VariableDxe.c is not for MM_STANDALONE, so I tried to use
> > "VarCheckPolicyLib" as VarCheckLib,
> > but "VarCheckPolicyLib" requires
> > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf and
> > DxeServicesLib.inf is not for MM_STANDALONE, I am stuck here.
> >
> > Could you please take a look at this error?
> >
> 
> Thanks for the report.
> 
> Bret, could you please suggest a fix here?

Re: VariablePolicy support in StandaloneMM

[Yao, Jiewen]

There are two issues:

1) Current VarCheckPolicyLib.inf does have DxeServicesLib, although the VarCheckPolicyLib.c does not include DxeServicesLib.h.

2) The current lib construction is traditional MM style.
EFI_STATUS
EFIAPI
VarCheckPolicyLibConstructor (
  IN EFI_HANDLE             ImageHandle,
  IN EFI_SYSTEM_TABLE       *SystemTable
  )

===============================

I agree with Liming that we need StandaloneMM instance. 
We can do below:
0) Remove DxeServicesLib from INF.

1) Redefine
EFI_STATUS
EFIAPI
VarCheckPolicyLibConstructor (
  IN EFI_HANDLE             ImageHandle,
  IN EFI_SYSTEM_TABLE       *SystemTable
  )
{}
to 
EFI_STATUS
EFIAPI
VarCheckPolicyLibCommonConstructor (
  VOID
  )
{}

2) Create a VarCheckPolicyLibTraditional.c, with below
EFI_STATUS
EFIAPI
VarCheckPolicyLibConstructor (
  IN EFI_HANDLE             ImageHandle,
  IN EFI_SYSTEM_TABLE       *SystemTable
  )
{
  return VarCheckPolicyLibCommonConstructor();
}

3) Create VarCheckPolicyLibStandaloneMm.inf and VarCheckPolicyLibStandaloneMm.c under MdeModulePkg\Library\VarCheckPolicyLib (same dir)
With below
EFI_STATUS
EFIAPI
VarCheckPolicyLibStandaloneConstructor (
  IN EFI_HANDLE             ImageHandle,
  IN EFI_MM_SYSTEM_TABLE       *MmSystemTable
  )
{
  return VarCheckPolicyLibCommonConstructor();
}

Maybe there is some other clean up needed.

===============================

At same time, we may need think about how to avoid the similar issue.
1) Maybe we should enable StandaloneMmPkg for CI build ?
2) I am a little surprised, why this is a runtime error instead of a build error ?

Thank you
Yao Jiewen


> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Wednesday, December 2, 2020 5:42 PM
> To: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; 'Masahisa Kojima'
> <masahisa.kojima@linaro.org>; 'edk2-devel-groups-io'
> <devel@edk2.groups.io>
> Cc: Bret.Barkelew@microsoft.com; Wang, Jian J <jian.j.wang@intel.com>;
> Wu, Hao A <hao.a.wu@intel.com>; 'Sami Mujawar'
> <sami.mujawar@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>; 'Laszlo
> Ersek' <lersek@redhat.com>
> Subject: 回复: VariablePolicy support in StandaloneMM
> 
> I just quick check. VarCheckPolicyLib doesn't consume DxeServicesLib. But,
> VarCheckPolicyLib library doesn't StandaloneMM type.
> 
> So, I think StandaloneMM version VarCheckPolicyLib is required.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > 发送时间: 2020年12月2日 17:02
> > 收件人: Masahisa Kojima <masahisa.kojima@linaro.org>;
> > edk2-devel-groups-io <devel@edk2.groups.io>
> > 抄送: Bret.Barkelew@microsoft.com; jian.j.wang@intel.com;
> > hao.a.wu@intel.com; gaoliming@byosoft.com.cn; Sami Mujawar
> > <sami.mujawar@arm.com>; jiewen.yao@intel.com; Laszlo Ersek
> > <lersek@redhat.com>
> > 主题: Re: VariablePolicy support in StandaloneMM
> >
> > (+ Laszlo)
> >
> > On 12/2/20 9:57 AM, Masahisa Kojima wrote:
> > > Hello All,
> > >
> > > VariablePolicy was introduced in November.
> > > When Developerbox(aarch64 platform) boots with UEFI secure boot
> > enabled,
> > > the following error appears.
> > > Note that this platform supports UEFI secure boot using the standalone
> > > MM framework.
> > >
> > > --- StandaloneMM log ---
> > > VariableLockRequestToLock - Failed to lock variable CapsuleMax! Not
> Ready
> > >
> > > ASSERT_EFI_ERROR (Status = Not Ready)
> > > ASSERT [VariableStandaloneMm]
> > >
> >
> /home/ubuntu/src/uefi/edk2/MdeModulePkg/Universal/Variable/RuntimeD
> x
> > e/VariableLockRequestToLock.c(64):
> > > !EFI_ERROR (Status)
> > > MmEntryPoint Done
> > > ---
> > >
> > > In my check, this is simply because
> > >
> >
> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c::InitVariablePol
> i
> > cyLib()
> > > is not called.
> > >
> > > InitVariablePolicyLib() is called from the following two files.
> > > ---
> > >   MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c:
> > Status
> > > = InitVariablePolicyLib( VariableServiceGetVariable );
> > >   MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c:  Status
> > =
> > > InitVariablePolicyLib (VariableServiceGetVariable);
> > > ---
> > > VariableDxe.c is not for MM_STANDALONE, so I tried to use
> > > "VarCheckPolicyLib" as VarCheckLib,
> > > but "VarCheckPolicyLib" requires
> > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf and
> > > DxeServicesLib.inf is not for MM_STANDALONE, I am stuck here.
> > >
> > > Could you please take a look at this error?
> > >
> >
> > Thanks for the report.
> >
> > Bret, could you please suggest a fix here?
> 

Re: VariablePolicy support in StandaloneMM

[Laszlo Ersek]

On 12/02/20 13:06, Yao, Jiewen wrote:
> There are two issues:
> 
> 1) Current VarCheckPolicyLib.inf does have DxeServicesLib, although the VarCheckPolicyLib.c does not include DxeServicesLib.h.
> 
> 2) The current lib construction is traditional MM style.
> EFI_STATUS
> EFIAPI
> VarCheckPolicyLibConstructor (
>   IN EFI_HANDLE             ImageHandle,
>   IN EFI_SYSTEM_TABLE       *SystemTable
>   )
> 
> ===============================
> 
> I agree with Liming that we need StandaloneMM instance. 
> We can do below:
> 0) Remove DxeServicesLib from INF.
> 
> 1) Redefine
> EFI_STATUS
> EFIAPI
> VarCheckPolicyLibConstructor (
>   IN EFI_HANDLE             ImageHandle,
>   IN EFI_SYSTEM_TABLE       *SystemTable
>   )
> {}
> to 
> EFI_STATUS
> EFIAPI
> VarCheckPolicyLibCommonConstructor (
>   VOID
>   )
> {}
> 
> 2) Create a VarCheckPolicyLibTraditional.c, with below
> EFI_STATUS
> EFIAPI
> VarCheckPolicyLibConstructor (
>   IN EFI_HANDLE             ImageHandle,
>   IN EFI_SYSTEM_TABLE       *SystemTable
>   )
> {
>   return VarCheckPolicyLibCommonConstructor();
> }
> 
> 3) Create VarCheckPolicyLibStandaloneMm.inf and VarCheckPolicyLibStandaloneMm.c under MdeModulePkg\Library\VarCheckPolicyLib (same dir)
> With below
> EFI_STATUS
> EFIAPI
> VarCheckPolicyLibStandaloneConstructor (
>   IN EFI_HANDLE             ImageHandle,
>   IN EFI_MM_SYSTEM_TABLE       *MmSystemTable
>   )
> {
>   return VarCheckPolicyLibCommonConstructor();
> }
> 
> Maybe there is some other clean up needed.
> 
> ===============================
> 
> At same time, we may need think about how to avoid the similar issue.
> 1) Maybe we should enable StandaloneMmPkg for CI build ?
> 2) I am a little surprised, why this is a runtime error instead of a build error ?

Thanks -- I have nothing to add. We need to extend CI coverage, and
indeed a new lib instance for this specific standalone MM module type
(if I understand correctly).

Sorry I can't be of more help.

Laszlo

> 
> Thank you
> Yao Jiewen
> 
> 
>> -----Original Message-----
>> From: gaoliming <gaoliming@byosoft.com.cn>
>> Sent: Wednesday, December 2, 2020 5:42 PM
>> To: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; 'Masahisa Kojima'
>> <masahisa.kojima@linaro.org>; 'edk2-devel-groups-io'
>> <devel@edk2.groups.io>
>> Cc: Bret.Barkelew@microsoft.com; Wang, Jian J <jian.j.wang@intel.com>;
>> Wu, Hao A <hao.a.wu@intel.com>; 'Sami Mujawar'
>> <sami.mujawar@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>; 'Laszlo
>> Ersek' <lersek@redhat.com>
>> Subject: 回复: VariablePolicy support in StandaloneMM
>>
>> I just quick check. VarCheckPolicyLib doesn't consume DxeServicesLib. But,
>> VarCheckPolicyLib library doesn't StandaloneMM type.
>>
>> So, I think StandaloneMM version VarCheckPolicyLib is required.
>>
>> Thanks
>> Liming
>>> -----邮件原件-----
>>> 发件人: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>> 发送时间: 2020年12月2日 17:02
>>> 收件人: Masahisa Kojima <masahisa.kojima@linaro.org>;
>>> edk2-devel-groups-io <devel@edk2.groups.io>
>>> 抄送: Bret.Barkelew@microsoft.com; jian.j.wang@intel.com;
>>> hao.a.wu@intel.com; gaoliming@byosoft.com.cn; Sami Mujawar
>>> <sami.mujawar@arm.com>; jiewen.yao@intel.com; Laszlo Ersek
>>> <lersek@redhat.com>
>>> 主题: Re: VariablePolicy support in StandaloneMM
>>>
>>> (+ Laszlo)
>>>
>>> On 12/2/20 9:57 AM, Masahisa Kojima wrote:
>>>> Hello All,
>>>>
>>>> VariablePolicy was introduced in November.
>>>> When Developerbox(aarch64 platform) boots with UEFI secure boot
>>> enabled,
>>>> the following error appears.
>>>> Note that this platform supports UEFI secure boot using the standalone
>>>> MM framework.
>>>>
>>>> --- StandaloneMM log ---
>>>> VariableLockRequestToLock - Failed to lock variable CapsuleMax! Not
>> Ready
>>>>
>>>> ASSERT_EFI_ERROR (Status = Not Ready)
>>>> ASSERT [VariableStandaloneMm]
>>>>
>>>
>> /home/ubuntu/src/uefi/edk2/MdeModulePkg/Universal/Variable/RuntimeD
>> x
>>> e/VariableLockRequestToLock.c(64):
>>>> !EFI_ERROR (Status)
>>>> MmEntryPoint Done
>>>> ---
>>>>
>>>> In my check, this is simply because
>>>>
>>>
>> MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c::InitVariablePol
>> i
>>> cyLib()
>>>> is not called.
>>>>
>>>> InitVariablePolicyLib() is called from the following two files.
>>>> ---
>>>>   MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c:
>>> Status
>>>> = InitVariablePolicyLib( VariableServiceGetVariable );
>>>>   MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c:  Status
>>> =
>>>> InitVariablePolicyLib (VariableServiceGetVariable);
>>>> ---
>>>> VariableDxe.c is not for MM_STANDALONE, so I tried to use
>>>> "VarCheckPolicyLib" as VarCheckLib,
>>>> but "VarCheckPolicyLib" requires
>>>> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf and
>>>> DxeServicesLib.inf is not for MM_STANDALONE, I am stuck here.
>>>>
>>>> Could you please take a look at this error?
>>>>
>>>
>>> Thanks for the report.
>>>
>>> Bret, could you please suggest a fix here?
>>
> 

Re: [edk2-devel] VariablePolicy support in StandaloneMM

[Kun Qin]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi Jiewen,

I agree with your proposal and implemented the changes you proposed here: kuqin12/mu_basecore at personal/kuqin/var_check (github.com) ( https://github.com/kuqin12/mu_basecore/tree/personal/kuqin/var_check ). Could you please take a look?

Both traditional and standalone instances are tested on our platforms internally, which rendered no issues on compilability or functionality.

Regards,
Kun

[-- Attachment #2: Type: text/html, Size: 459 bytes --]

Re: [edk2-devel] VariablePolicy support in StandaloneMM

[Masahisa Kojima]

Hi Kun,

> I agree with your proposal and implemented the changes you proposed here: kuqin12/mu_basecore at personal/kuqin/var_check (github.com). Could you please take a look?

I have applied your patch to edk2(slightly modified from mu_basecode
to edk2) and works also fine in my environment.
Is it OK to send these patches to edk2-devel with your "Signed-off-by"?

Best Regards,
Masahisa


On Fri, 4 Dec 2020 at 06:58, Kun Qin <kun.q@outlook.com> wrote:
>
> Hi Jiewen,
>
> I agree with your proposal and implemented the changes you proposed here: kuqin12/mu_basecore at personal/kuqin/var_check (github.com). Could you please take a look?
>
> Both traditional and standalone instances are tested on our platforms internally, which rendered no issues on compilability or functionality.
>
> Regards,
> Kun
> 

Re: [edk2-devel] VariablePolicy support in StandaloneMM

[Kun Qin]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

Hi Masahisa,

Thanks for testing the patches. It is OK to send these patches to the mailing list with my "Signed-off-by" tag. Please let me know if anything specific is needed from me in order to get these patches into the mainline.

Thanks,
Kun

[-- Attachment #2: Type: text/html, Size: 321 bytes --]

Re: [edk2-devel] VariablePolicy support in StandaloneMM

[Masahisa Kojima]

Hi Kun,

I overlooked that SmmIsBufferOutsideSmmValid() is not available in StandaloneMM.
I created a wrapper function to call SmmIsBufferOutsideSmmValid() in
Traditional MM
and MmIsBufferOutsideMmValid() in Standalone MM.

I modified many files from your original patches, I will submit the
patch to edk2-devel
with your name as "Co-authored-by:" instead of "Signed-off-by",
since only one "Signed-off-by" accepted edk2 in my understanding.

Thanks,
Masahisa

On Tue, 15 Dec 2020 at 07:20, Kun Qin <kun.q@outlook.com> wrote:
>
> Hi Masahisa,
>
> Thanks for testing the patches. It is OK to send these patches to the mailing list with my "Signed-off-by" tag. Please let me know if anything specific is needed from me in order to get these patches into the mainline.
>
> Thanks,
> Kun

Re: [edk2-devel] VariablePolicy support in StandaloneMM

[Kun Qin]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

Hi Masahisa,

Thanks for sending the patches.

A side note about " MmIsBufferOutsideMmValid ": I recently found that this implementation will always return true for me because the " mMmMemLibInternalMmramCount " and " mMmMemLibInternalMmramRanges " was never initialized. I have a fix/change for x64 arch here: mu_basecore/StandaloneMmPkg/Library/StandaloneMmMemLib at personal/kuqin/standalone_x64 · kuqin12/mu_basecore (github.com) ( https://github.com/kuqin12/mu_basecore/tree/personal/kuqin/standalone_x64/StandaloneMmPkg/Library/StandaloneMmMemLib ). Please let me know how you think, otherwise I will send out patches for this library.

Regards,
Kun

[-- Attachment #2: Type: text/html, Size: 1092 bytes --]

回复: [edk2-devel] VariablePolicy support in StandaloneMM

[gaoliming]

Masahisa:
  There is no limitation for only one Signed-off-by. You can add one or more if more people contribute it. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+68961+4905953+8761045@groups.io
> <bounce+27952+68961+4905953+8761045@groups.io> 代表 Masahisa
> Kojima
> 发送时间: 2020年12月16日 19:54
> 收件人: Kun Qin <kun.q@outlook.com>
> 抄送: edk2-devel-groups-io <devel@edk2.groups.io>
> 主题: Re: [edk2-devel] VariablePolicy support in StandaloneMM
> 
> Hi Kun,
> 
> I overlooked that SmmIsBufferOutsideSmmValid() is not available in
> StandaloneMM.
> I created a wrapper function to call SmmIsBufferOutsideSmmValid() in
> Traditional MM
> and MmIsBufferOutsideMmValid() in Standalone MM.
> 
> I modified many files from your original patches, I will submit the
> patch to edk2-devel
> with your name as "Co-authored-by:" instead of "Signed-off-by",
> since only one "Signed-off-by" accepted edk2 in my understanding.
> 
> Thanks,
> Masahisa
> 
> On Tue, 15 Dec 2020 at 07:20, Kun Qin <kun.q@outlook.com> wrote:
> >
> > Hi Masahisa,
> >
> > Thanks for testing the patches. It is OK to send these patches to the mailing
> list with my "Signed-off-by" tag. Please let me know if anything specific is
> needed from me in order to get these patches into the mainline.
> >
> > Thanks,
> > Kun
> 
> 
> 
> 

Re: [edk2-devel] VariablePolicy support in StandaloneMM

[Masahisa Kojima]

Hi Liming,

>   There is no limitation for only one Signed-off-by. You can add one or more if more people contribute it.
Noted.

Thanks,
Masahisa

On Thu, 17 Dec 2020 at 10:10, gaoliming <gaoliming@byosoft.com.cn> wrote:
>
> Masahisa:
>   There is no limitation for only one Signed-off-by. You can add one or more if more people contribute it.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+68961+4905953+8761045@groups.io
> > <bounce+27952+68961+4905953+8761045@groups.io> 代表 Masahisa
> > Kojima
> > 发送时间: 2020年12月16日 19:54
> > 收件人: Kun Qin <kun.q@outlook.com>
> > 抄送: edk2-devel-groups-io <devel@edk2.groups.io>
> > 主题: Re: [edk2-devel] VariablePolicy support in StandaloneMM
> >
> > Hi Kun,
> >
> > I overlooked that SmmIsBufferOutsideSmmValid() is not available in
> > StandaloneMM.
> > I created a wrapper function to call SmmIsBufferOutsideSmmValid() in
> > Traditional MM
> > and MmIsBufferOutsideMmValid() in Standalone MM.
> >
> > I modified many files from your original patches, I will submit the
> > patch to edk2-devel
> > with your name as "Co-authored-by:" instead of "Signed-off-by",
> > since only one "Signed-off-by" accepted edk2 in my understanding.
> >
> > Thanks,
> > Masahisa
> >
> > On Tue, 15 Dec 2020 at 07:20, Kun Qin <kun.q@outlook.com> wrote:
> > >
> > > Hi Masahisa,
> > >
> > > Thanks for testing the patches. It is OK to send these patches to the mailing
> > list with my "Signed-off-by" tag. Please let me know if anything specific is
> > needed from me in order to get these patches into the mainline.
> > >
> > > Thanks,
> > > Kun
> >
> >
> >
> >
>
>
>
>
>
> 
>
>