From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from huawei.com (huawei.com [45.249.212.32]) by mx.groups.io with SMTP id smtpd.web10.7204.1590589890788244666 for ; Wed, 27 May 2020 07:31:31 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.32, mailfrom: huangming23@huawei.com) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 6588DB61EBAEB0E65305; Wed, 27 May 2020 22:31:23 +0800 (CST) Received: from [127.0.0.1] (10.78.51.60) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Wed, 27 May 2020 22:31:16 +0800 Subject: Re: [RFC edk2-platforms v1 0/3] Improve D0x To: Leif Lindholm CC: , , , , , References: <1590072184-16219-1-git-send-email-huangming23@huawei.com> <20200526180920.GO1923@vanye> From: Ming Huang Message-ID: Date: Wed, 27 May 2020 22:31:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20200526180920.GO1923@vanye> X-Originating-IP: [10.78.51.60] X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable =E5=9C=A8 2020/5/27 2:09, Leif Lindholm =E5=86=99=E9=81=93: > On trying to build the resulting output, I found the build breaks with > /work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvb= Dxe.c: > In function =E2=80=98FlashFvbInitialize=E2=80=99: > /work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvb= Dxe.c:1231:20: > error: =E2=80=98gEfiEventVirtualAddressChangeGuid=E2=80=99 undeclared (= first use in > this function); did you mean =E2=80=98EfiSetVirtualAddressMap=E2=80=99? > &gEfiEventVirtualAddressChangeGuid, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > EfiSetVirtualAddressMap >=20 > The error would appear identical to that resolved by > commit a327627dd3f9edc113b1de6d897222d0517834db >=20 > Could you please provide a corresponding fix? Ok, I will add a patch in v2. Thanks, Ming >=20 > Best Regards, >=20 > Leif >=20 > On Thu, May 21, 2020 at 22:43:01 +0800, Ming Huang wrote: >> Main Changes: >> Add update sas address feature in AcpiPlatformDxe. >> >> Ming Huang (3): >> Silicon/Hisilicon: Change updating dsdt in ready to boot event >> Silicon/Hisilicon/Acpi: Add update sas address feature >> Silicon/Hisilicon: Rename EthMac files >> >> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 62 += - >> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 8 += - >> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c | 500 -= --------------- >> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h | 16 - >> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c | 612 += +++++++++++++++++++ >> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h | 16 + >> 6 files changed, 689 insertions(+), 525 deletions(-) >> delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c >> delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h >> create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDs= dt.c >> create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDs= dt.h >> >> --=20 >> 2.8.1 >> >=20 > . >=20