From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9BC622119BAD3 for ; Mon, 17 Dec 2018 01:54:31 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0962486663; Mon, 17 Dec 2018 09:54:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-46.rdu2.redhat.com [10.10.120.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 933696012B; Mon, 17 Dec 2018 09:54:26 +0000 (UTC) To: "Ni, Ruiyu" , "Justen, Jordan L" , Ard Biesheuvel , Anthony Perard , Julien Grall Cc: "edk2-devel@lists.01.org" , Kevin O'Connor , Gerd Hoffmann , David Woodhouse References: <734D49CCEBEEF84792F5B80ED585239D5BF6035C@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: Date: Mon, 17 Dec 2018 10:54:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BF6035C@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 17 Dec 2018 09:54:31 +0000 (UTC) Subject: Re: Drop CSM support in OvmfPkg? X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 09:54:31 -0000 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit (Adding Kevin, Gerd, David) On 12/17/18 03:23, Ni, Ruiyu wrote: > Hi OvmfPkg maintainers and reviewers, > I am working on removing IntelFrameworkModulePkg and IntelFrameworkPkg. The biggest dependency now I see is the CSM components that OVMF depends on. > So I'd like to know your opinion about how to handle this. I see two options here: > > 1. Drop CSM support in OvmfPkg. > 2. Create a OvmfPkg/Csm folder to duplicate all CSM components there. > > What's your opinion about this? (1) Personally I never use CSM builds of OVMF. The OVMF builds in RHEL and Fedora also don't enable the CSM (mainly because I had found debugging & supporting the CSM *extremely* difficult). For virtualization, we generally recommend "use SeaBIOS directly if you need a traditional BIOS guest". (2) I'd be definitely unhappy about having to maintain the platform-independent CSM components under OvmfPkg (such as LegacyBootManagerLib, LegacyBootMaintUiLib, LegacyBiosDxe, VideoDxe). (3) However, David and Kevin had put a *lot* of work into enabling SeaBIOS to function as a CSM in combination with OVMF. Today, the CSM target is a dedicated / separate "build mode" of SeaBIOS. (4) I also think an open source CSM implementation should exist, just so people can study it and experiment with it. The CSM specification (from Intel) is a public document, and the edk2 code is the reference implementation for it. Killing the reference implementation makes the spec mostly useless. Are Intel withdrawing the spec too? (Or has that happened already?) In short, I think the community would benefit if someone continued to maintain the CSM infrastructure in edk2, but personally I won't volunteer. I also understand if Intel has no more resources for it. Removing CSM from edk2 altogether (including OVMF) might be the natural (albeit regrettable) result. Thanks Laszlo