From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id B37572063D74B
 for <edk2-devel@lists.01.org>; Wed, 11 Jul 2018 05:15:34 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
 [10.11.54.5])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 00DC74075C79;
 Wed, 11 Jul 2018 12:15:34 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-194.rdu2.redhat.com
 [10.10.120.194])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 5418176CF;
 Wed, 11 Jul 2018 12:15:32 +0000 (UTC)
From: Laszlo Ersek <lersek@redhat.com>
To: rbacik@gmail.com, edk2-devel@lists.01.org
Cc: Jiewen Yao <jiewen.yao@intel.com>,
 Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
 Chao Zhang <chao.b.zhang@intel.com>,
 "Jordan Justen (Intel address)" <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Michael Kinney <michael.d.kinney@intel.com>,
 "Gao, Liming" <liming.gao@intel.com>, "Carsey, Jaben"
 <jaben.carsey@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>
References: <20180710225105.28443-1-roman.bacik@broadcom.com>
 <5bca3f43-7c23-dca6-03cd-2d647d8fe253@redhat.com>
Message-ID: <c26e1dec-7f48-54b3-f088-ec2d517353a2@redhat.com>
Date: Wed, 11 Jul 2018 14:15:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <5bca3f43-7c23-dca6-03cd-2d647d8fe253@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.5]); Wed, 11 Jul 2018 12:15:34 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]);
 Wed, 11 Jul 2018 12:15:34 +0000 (UTC) for IP:'10.11.54.5'
 DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jul 2018 12:15:34 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/11/18 14:05, Laszlo Ersek wrote:

> - The OpenFileByDevicePath() function is duplicated in the following
> modules: "NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c", and
> "MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskFileExplorer.c". With the
> implication that the alignment issue you found affects all three drivers!

Note that I've mutually diffed the three function definitions between
each other (with "diff -b"), and there are only whitespace and comment
wrapping differences.

So, again, this function looks like a prime suspect for UefiLib.

I do see the strange reference at the end ("undefined SHELL_FILE_HANDLE
format"); I think that's simply stale, and should be removed.

Thanks
Laszlo