From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 03D91AC1972 for ; Fri, 29 Mar 2024 20:24:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dcP/cbmKiUChIZMmgMSOzSKo8onbf1UK4pVMPVBmQ/o=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711743857; v=1; b=SqUR8uVB8ySPhSwIaHugf7sgosCXP334MietRCLvcGxBI9mNrABVVObio/4ckcjqHXhGTRcM Di73qrw5m4IBjl/F2wn+s+Odc3qKPEZZo9ZCtZc83TN9H63MPnd+qQzWa7NDl4toA9/8yv+RqYU 1gIepfftGd/BR7YuPgz4kLDOJokV9kOu3bj+tb0beRQybAI9k8LdKh2EFombxjmlZIZ6JfkLX/q nQuczNXAZH8QrPLGc45SB1C4MawBpt7PgN719LzGB8b2ZcQyODY6OBbWpLAYAdoavgz3LETbZ54 SVulfSzwuROJtTI8VPFuTD1nHwxhyvSJtR5z9unc86LZw== X-Received: by 127.0.0.2 with SMTP id rWINYY7687511xfeXMK5pQl8; Fri, 29 Mar 2024 13:24:17 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.1044.1711743857151036631 for ; Fri, 29 Mar 2024 13:24:17 -0700 X-Received: from [10.137.194.171] (unknown [131.107.159.43]) by linux.microsoft.com (Postfix) with ESMTPSA id B5A2D20E6F42; Fri, 29 Mar 2024 13:24:16 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B5A2D20E6F42 Message-ID: Date: Fri, 29 Mar 2024 13:24:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v3 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes From: "Oliver Smith-Denny" To: devel@edk2.groups.io, Michael Kinney Cc: Liming Gao , Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Taylor Beebe Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com References: <17C155D00B87C04B.23967@groups.io> In-Reply-To: <17C155D00B87C04B.23967@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 29 Mar 2024 13:24:17 -0700 List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QHseBQZrVMmwfr0AHzyJhMlBx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=SqUR8uVB; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Sorry Mike, I realized I missed you on the cover letter email. I have the CI PR up (the commit messages there don't have the RBs/AB) and I made sure it passed all gates. Thanks for getting this merged. Oliver On 3/29/2024 1:21 PM, Oliver Smith-Denny wrote: > ImagePropertiesRecordLib is currently creating Image Records that > are not accurate. It is setting the CodeSegmentSize to be the size > of the raw data in the image file, however, when the image is > loaded into memory, the raw data size is aligned to the > section alignment. This caused the memory attributes table to > have incorrect entries for systems, like ARM64, where the section > alignment is not 4k for all modules. >=20 > In fixing this, I noticed that MemoryProtection.c is using its own > version of image record creation where this logic was actually > correct. ImagePropertiesRecordLib was created to consolidate the > logic around creating and managing image records, so this patchset > also updates MemoryProtection.c to use ImagePropertiesRecordsLib > after making a few small adjustments to ensure the same functionality > is present. >=20 > This patchset was tested on ArmVirtQemu to ensure that all image > records were the same before and after this, other than fixing > the CodeSegmentSize. >=20 > v3: > - Fix merge conflict in MemoryProtection.c >=20 > v2: > - Align VirtualSize instead of SizeOfRawData >=20 > Github PR: https://github.com/tianocore/edk2/pull/5504 >=20 > Cc: Liming Gao > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Taylor Beebe >=20 > Oliver Smith-Denny (3): > MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for > CodeSize > MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage > MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib >=20 > Oliver Smith-Denny (3): > MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for > CodeSize > MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage > MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib >=20 > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c = | 241 +++----------------- > MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.= c | 86 +++++-- > 2 files changed, 94 insertions(+), 233 deletions(-) >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117244): https://edk2.groups.io/g/devel/message/117244 Mute This Topic: https://groups.io/mt/105223002/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-