From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 12 Apr 2019 00:54:40 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D782E81DEE; Fri, 12 Apr 2019 07:54:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-65.rdu2.redhat.com [10.10.120.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id A94BA1001E61; Fri, 12 Apr 2019 07:54:36 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64 To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Rebecca Cran , devel@edk2.groups.io, Liming Gao , Yonghong Zhu References: <20190411031653.38092-1-rebecca@bluestop.org> <19000479-83f6-49fb-7a68-e09b31cd0a0e@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 12 Apr 2019 09:54:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 12 Apr 2019 07:54:39 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 04/11/19 22:11, Philippe Mathieu-Daud=C3=A9 wrote: > On 4/11/19 9:58 PM, Rebecca Cran wrote: >> On 2019-04-11 13:55, Philippe Mathieu-Daud=C3=A9 wrote: >>> >>> With the work around link added: >>> Reviewed-by: Philippe Mathieu-Daude >> >> >> >> But it's _not_ working around that bug. That was about "uname -p", but >> the patch is about "uname -m". That sounds convincing, thank you for the clarification. I'd still say it's a workaround, just not for that specific FreeBSD BZ, because: > Ah you are right, the script simply parse the 'machine hardware name' t= o > extract the host architecture. We shouldn't rely on the 'processor type > name' which is non-portable. obviously the "machine hardware name" is non-portable either, when we consider FreeBSD. Either way I've obsessed enough about this. Reviewed-by: Laszlo Ersek Thanks Laszlo > Simply checking for 'arm64' is enough. >=20 > So do not add the link, and keep my tag: > Reviewed-by: Philippe Mathieu-Daude