From: "xianglai" <lixianglai@loongson.cn>
To: maobibo <maobibo@loongson.cn>, devel@edk2.groups.io
Cc: Chao Li <lichao@loongson.cn>
Subject: Re: [edk2-devel] [PATCH] Platform/Loongson: Remove minimium memory size limitation
Date: Wed, 27 Mar 2024 09:09:55 +0800 [thread overview]
Message-ID: <c28ac72c-aff7-7d9a-de71-f6cb1dce3ad1@loongson.cn> (raw)
In-Reply-To: <5c184b50-bda7-f82e-a959-6a11eee8884b@loongson.cn>
hi maobibo:
>
>
> On 2024/3/25 下午5:25, xianglai wrote:
>> From: Bibo Mao <maobibo@loongson.cn>
>>
>> Temparory stack memory on PEI is hardcoded now, also minimium memory
>>
[......]
>> +
>> + QemuFwCfgSelectItem (FwCfgItem);
>> + for (Processed = 0; Processed < FwCfgSize; Processed += sizeof MemoryMapEntry) {
>> + QemuFwCfgReadBytes (sizeof MemoryMapEntry, &MemoryMapEntry);
>> + if (MemoryMapEntry.Type != EfiAcpiAddressRangeMemory) {
>> + continue;
>> + }
>> +
>> + /*
>> + * Find memory map entry where PEI temp stack is located
>> + */
>> + if ((MemoryMapEntry.BaseAddr <= Base) &&
>> + (Base < (MemoryMapEntry.BaseAddr + MemoryMapEntry.Length))) {
>> + RamTop = MemoryMapEntry.BaseAddr + MemoryMapEntry.Length;
> Xianglai,
>
> Will it be better if there is one "break" sentence?
Ok,I will fix it in the next version.
Thanks,
Xianglai.
>
> Regards
> Bibo Mao
>
>> + }
>> + }
>> +
>> + if (RamTop == 0) {
>> + DEBUG ((DEBUG_ERROR, "ERROR: No memory map entry contains temp stack \n"));
>> + ASSERT (FALSE);
>> + }
>>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117144): https://edk2.groups.io/g/devel/message/117144
Mute This Topic: https://groups.io/mt/105134610/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-03-27 1:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 9:25 [edk2-devel] [PATCH] Platform/Loongson: Remove minimium memory size limitation xianglai
2024-03-26 1:10 ` maobibo
2024-03-27 1:09 ` xianglai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c28ac72c-aff7-7d9a-de71-f6cb1dce3ad1@loongson.cn \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox