From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 94AFFD81163 for ; Wed, 27 Mar 2024 01:10:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=N0MsjX/x8fXEKEUsFQ+ZKYy4lf2VNRfnObifB/ErOyk=; c=relaxed/simple; d=groups.io; h=Subject:To:Cc:References:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1711501805; v=1; b=Qzodxede+eYVc2Cd+Hqp3YDnxziEro7iohf9wD6z44Jk5hUWCSe2/G/NCBDM/cvkexpH/t2Q ZPgmORhgBGYsvVHtJ7SINf1j+2oXEluRy+WIwnqg11QV3DE3xLzSOjLH0YaUuN+MgybMWYZcjl0 WgD3oSzCEC+zRrNXCDPz98aNcXQI3sYs7vrajmoTSOoxYpLToa7tDT9rxDhHoXN5+dEGynUg+Ns lNEZOhk2JKzPwT2c16gsV0ps5llypjJIlTDDAV4xyfSgPQ5aFjo/dF35FRQa5QiJMWhGHzb+A26 PgXL77Cy5L/A1gzNYi0A5G+RkCC2/HS+Hu9kYtAqv0wFA== X-Received: by 127.0.0.2 with SMTP id GbmPYY7687511xyCD5f4S0wS; Tue, 26 Mar 2024 18:10:05 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.26813.1711501803448750343 for ; Tue, 26 Mar 2024 18:10:04 -0700 X-Received: from loongson.cn (unknown [10.20.42.32]) by gateway (Coremail) with SMTP id _____8CxF+jmcQNmvpoeAA--.51861S3; Wed, 27 Mar 2024 09:09:59 +0800 (CST) X-Received: from [10.20.42.32] (unknown [10.20.42.32]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxEOXjcQNm2I5pAA--.15237S2; Wed, 27 Mar 2024 09:09:57 +0800 (CST) Subject: Re: [edk2-devel] [PATCH] Platform/Loongson: Remove minimium memory size limitation To: maobibo , devel@edk2.groups.io Cc: Chao Li References: <20240325092531.2036269-1-lixianglai@loongson.cn> <5c184b50-bda7-f82e-a959-6a11eee8884b@loongson.cn> From: "xianglai" Message-ID: Date: Wed, 27 Mar 2024 09:09:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <5c184b50-bda7-f82e-a959-6a11eee8884b@loongson.cn> X-CM-TRANSID: AQAAf8DxEOXjcQNm2I5pAA--.15237S2 X-CM-SenderInfo: 5ol0xt5qjotxo6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj9xXoW7GFW5uw47Cr15tF1DCFWfJFc_yoWkurb_Xw 4UW3WUZF4DX3yDJr4DW3srZrW3XrWvvw15WF43Aw48GFyfJrZ5Jrn8Xwn5WF1UGrWjyr97 Ary5G3W3X340qosvyTuYvTs0mTUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbxxYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z280aVCY1x0267AKxVW8 JVW8Jr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67 vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AK xVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr 1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUzsqWUUUU U Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 26 Mar 2024 18:10:04 -0700 Reply-To: devel@edk2.groups.io,lixianglai@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vtI34sUkCzvljNnhK4954QaKx7686176AA= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Qzodxede; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none hi  maobibo: > > > On 2024/3/25 下午5:25, xianglai wrote: >> From: Bibo Mao >> >> Temparory stack memory on PEI is hardcoded now, also minimium memory >> [......] >> + >> +  QemuFwCfgSelectItem (FwCfgItem); >> +  for (Processed = 0; Processed < FwCfgSize; Processed += sizeof MemoryMapEntry) { >> +    QemuFwCfgReadBytes (sizeof MemoryMapEntry, &MemoryMapEntry); >> +    if (MemoryMapEntry.Type != EfiAcpiAddressRangeMemory) { >> +      continue; >> +    } >> + >> +    /* >> +     * Find memory map entry where PEI temp stack is located >> +     */ >> +    if ((MemoryMapEntry.BaseAddr <= Base) && >> +        (Base < (MemoryMapEntry.BaseAddr + MemoryMapEntry.Length))) { >> +        RamTop = MemoryMapEntry.BaseAddr + MemoryMapEntry.Length; > Xianglai, > > Will it be better if there is one "break" sentence? Ok,I will fix it in the next version. Thanks, Xianglai. > > Regards > Bibo Mao > >> +    } >> +  } >> + >> +  if (RamTop == 0) { >> +    DEBUG ((DEBUG_ERROR, "ERROR: No memory map entry contains temp stack \n")); >> +    ASSERT (FALSE); >> +  } >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117144): https://edk2.groups.io/g/devel/message/117144 Mute This Topic: https://groups.io/mt/105134610/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-