From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id CD62681F1B
 for <edk2-devel@ml01.01.org>; Fri, 25 Nov 2016 03:11:26 -0800 (PST)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 42CB8C054904;
 Fri, 25 Nov 2016 11:11:26 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-35.phx2.redhat.com
 [10.3.116.35])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 uAPBBOqa003685; Fri, 25 Nov 2016 06:11:25 -0500
To: Jeff Fan <jeff.fan@intel.com>, edk2-devel@ml01.01.org
References: <20161125060312.27932-1-jeff.fan@intel.com>
 <20161125060312.27932-6-jeff.fan@intel.com>
Cc: Feng Tian <feng.tian@intel.com>,
 Michael D Kinney <michael.d.kinney@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <c2a7f897-c7e7-c945-f9b5-d850fc2eb450@redhat.com>
Date: Fri, 25 Nov 2016 12:11:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.0
MIME-Version: 1.0
In-Reply-To: <20161125060312.27932-6-jeff.fan@intel.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.32]); Fri, 25 Nov 2016 11:11:26 +0000 (UTC)
Subject: Re: [PATCH v2 5/5] UefiCpuPkg/DxeMpLib: Remove unnecessary ret instruction
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Nov 2016 11:11:26 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 11/25/16 07:03, Jeff Fan wrote:
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan <jeff.fan@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 1 -
>  UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm b/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm
> index a48f0bc..52363e6 100644
> --- a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm
> +++ b/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm
> @@ -244,7 +244,6 @@ HltLoop:
>      cli
>      hlt
>      jmp        HltLoop
> -    ret
>  AsmRelocateApLoopEnd:
>  
>  ;-------------------------------------------------------------------------------------
> diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
> index 34c07a6..fa54d01 100644
> --- a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
> +++ b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm
> @@ -274,7 +274,6 @@ HltLoop:
>      cli
>      hlt
>      jmp        HltLoop
> -    ret
>  BITS 64
>  AsmRelocateApLoopEnd:
>  
> 

Right, thank you for removing the superfluous RET from the Ia32 code as
well, my report covered the X64 case only, and I noticed Ia32 only later.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Please hold off committing the series just yet, I'd like to test it as
well. I'll report back with results.

Thanks!
Laszlo