public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: rebecca@bluestop.org
To: Jian Wang <jian.j.wang@intel.com>, Ting Ye <ting.ye@intel.com>,
	devel@edk2.groups.io
Subject: Re: [PATCH] CryptoPkg: define DSO_NONE in the OpenSSL build
Date: Thu, 13 Jun 2019 17:38:53 -0600	[thread overview]
Message-ID: <c2b518ac-0f99-71b5-1c7f-8a38909cc972@bluestop.org> (raw)
In-Reply-To: <20190613233239.54074-1-rebecca@bluestop.org>

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

On 2019-06-13 17:32, Rebecca Cran wrote:
> This fixes the build on FreeBSD, where DSO_METHOD_openssl is undefined
> since dso_openssl.c only compiles the function if DSO_NONE is defined.

Sorry, I just realized this isn't applicable to the OpenSSL we currently
pull in: I was testing against OpenSSL_1_1_1-stable where they changed
the configuration in
https://github.com/openssl/openssl/commit/5fba3afad01707f4a8856a35500de007a8a256ec#diff-e1ea891baa345b284ad0a5a663bb9b20
:


"Rework DSO API conditions and configuration option

'no-dso' is meaningless, as it doesn't get any macro defined.
Therefore, we remove all checks of OPENSSL_NO_DSO.  However, there may
be some odd platforms with no DSO scheme.  For those, we generate the
internal macro DSO_NONE aand use it."



So please ignore this.


-- 
Rebecca Cran


[-- Attachment #2: Type: text/html, Size: 1455 bytes --]

      reply	other threads:[~2019-06-13 23:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 23:32 [PATCH] CryptoPkg: define DSO_NONE in the OpenSSL build rebecca
2019-06-13 23:38 ` rebecca [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2b518ac-0f99-71b5-1c7f-8a38909cc972@bluestop.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox