From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web09.14245.1583156790876862520 for ; Mon, 02 Mar 2020 05:46:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KYd395iv; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583156790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i4FYY9YWN2MFeZm1S7t1+aFckWpGwrIW9GTzYcQyf7Y=; b=KYd395ivUiZ1EBdx7eTdeU37MUWidqoL+ynAKITjs3/7K9mfz/OGU9EP4H4qeXbEgjeZ9a KxTR86BkarNPuCPlmpNsdY4TouZk3y1Lz2TuOb/OPyBHuL6s/KsvUeuEZRnvYWK8xDS+EX PnTiTJhe7Z4dcf2D3t8T8RfSgd9SRso= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-F0kcnf60NZyCsqDsaVCnQQ-1; Mon, 02 Mar 2020 08:46:28 -0500 X-MC-Unique: F0kcnf60NZyCsqDsaVCnQQ-1 Received: by mail-wm1-f69.google.com with SMTP id 7so2337981wmo.7 for ; Mon, 02 Mar 2020 05:46:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jHxI7xF+Kr0FRVjSw6p6Tf2l1c1LstForXOQkZH1nTE=; b=G1UTASYU04u7ZLITiZihAccL97h6fPoznik5NjVkoCEDBSTgHbZaeT1KKhE50CuShL iHX8mn0/3vJ0hqAprGkyL3g6n5chCMRya4h0XGykxJb72hA5jdRHKBx3V52vDm4YhOH7 s+U/TB+GmQCNZqMiAk3faH8GWbwMrKTZ8EbC2FlvJcqoKudfLzdCtCy+WQfswsDFGY5f JQHVl2eHAjGr1U5jby34U8fyelgfTQyrN/someAoWNuyRsRH9KNWlzkpwlVsf9Mh/ltB uSF06hHfR2iOuFcJfejPL+Q3Q2XCQ2xa1+tt3w5zRDm6DWLzZ8G8L85ilhwx1lGa2z62 bQ5A== X-Gm-Message-State: APjAAAUGRJY9NvdwvBeDqecp/I/maQZXrjeA8r3QrQQ+dFeAF/zZkzpm MLotfJXFNB/20Oud72yEXFeBzAMd4FrqxMolU7LbP4EkWmAdsnmeb0UXdhJsLVNPoTe5g7gPl4K y/rUu0VeHu6TS/A== X-Received: by 2002:adf:90ee:: with SMTP id i101mr22055811wri.417.1583156786837; Mon, 02 Mar 2020 05:46:26 -0800 (PST) X-Google-Smtp-Source: APXvYqwyJoL5O1kS03qhDrPcvJ/Tt2B6vBUejAIy8UykdjNw1joSpryHVsQ73EwZZ6XqMk+uYhs54A== X-Received: by 2002:adf:90ee:: with SMTP id i101mr22055803wri.417.1583156786621; Mon, 02 Mar 2020 05:46:26 -0800 (PST) Return-Path: Received: from ?IPv6:2a01:e35:2fb0:49e0:3f7b:4b69:b9c:cdc0? ([2a01:e35:2fb0:49e0:3f7b:4b69:b9c:cdc0]) by smtp.gmail.com with ESMTPSA id f6sm1621038wmh.29.2020.03.02.05.46.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2020 05:46:26 -0800 (PST) Subject: Re: [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start failure To: Laszlo Ersek , edk2-devel-groups-io Cc: Ard Biesheuvel , Eric Dong , Hao A Wu , Igor Mammedov , Jian J Wang , Jiewen Yao , Jordan Justen , Michael Kinney , Ray Ni References: <20200226221156.29589-1-lersek@redhat.com> <20200226221156.29589-2-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Mon, 2 Mar 2020 14:46:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200226221156.29589-2-lersek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2/26/20 11:11 PM, Laszlo Ersek wrote: > In the CoreStartImage() function [MdeModulePkg/Core/Dxe/Image/Image.c], i= f > the image entry point returns a failure code, then the DXE Core logs a > helpful DEBUG_ERROR message, with the following format string: >=20 > "Error: Image at %11p start failed: %r\n" >=20 > Do similarly in the SMM Core (update the message slightly). >=20 > Cc: Ard Biesheuvel > Cc: Eric Dong > Cc: Hao A Wu > Cc: Igor Mammedov > Cc: Jian J Wang > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Michael Kinney > Cc: Philippe Mathieu-Daud=C3=A9 > Cc: Ray Ni > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1512 > Signed-off-by: Laszlo Ersek > Acked-by: Ard Biesheuvel > --- >=20 > Notes: > v2: > =20 > - Pick up Ard's Acked-by, which is conditional on approval from Inte= l > reviewers on Cc. (I'd like to save Ard the churn of re-acking > unmodified patches.) >=20 > MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c b/MdeModulePkg/Core= /PiSmmCore/Dispatcher.c > index 9bec731e5312..76ee9e0b89cc 100644 > --- a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c > +++ b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c > @@ -883,44 +883,50 @@ SmmDispatcher ( > RemoveEntryList (&DriverEntry->ScheduledLink); > =20 > REPORT_STATUS_CODE_WITH_EXTENDED_DATA ( > EFI_PROGRESS_CODE, > EFI_SOFTWARE_SMM_DRIVER | EFI_SW_PC_INIT_BEGIN, > &DriverEntry->ImageHandle, > sizeof (DriverEntry->ImageHandle) > ); > =20 > // > // Cache state of SmmEntryPointRegistered before calling entry po= int > // > PreviousSmmEntryPointRegistered =3D gSmmCorePrivate->SmmEntryPoin= tRegistered; > =20 > // > // For each SMM driver, pass NULL as ImageHandle > // > RegisterSmramProfileImage (DriverEntry, TRUE); > PERF_START_IMAGE_BEGIN (DriverEntry->ImageHandle); > Status =3D ((EFI_IMAGE_ENTRY_POINT)(UINTN)DriverEntry->ImageEntry= Point)(DriverEntry->ImageHandle, gST); > PERF_START_IMAGE_END (DriverEntry->ImageHandle); > if (EFI_ERROR(Status)){ > + DEBUG (( > + DEBUG_ERROR, > + "Error: SMM image at %11p start failed: %r\n", > + DriverEntry->SmmLoadedImage.ImageBase, > + Status > + )); > UnregisterSmramProfileImage (DriverEntry, TRUE); > SmmFreePages(DriverEntry->ImageBuffer, DriverEntry->NumberOfPag= e); > // > // Uninstall LoadedImage > // > Status =3D gBS->UninstallProtocolInterface ( > DriverEntry->ImageHandle, > &gEfiLoadedImageProtocolGuid, > DriverEntry->LoadedImage > ); > if (!EFI_ERROR (Status)) { > if (DriverEntry->LoadedImage->FilePath !=3D NULL) { > gBS->FreePool (DriverEntry->LoadedImage->FilePath); > } > gBS->FreePool (DriverEntry->LoadedImage); > } > Status =3D SmmUninstallProtocolInterface ( > DriverEntry->SmmImageHandle, > &gEfiLoadedImageProtocolGuid, > &DriverEntry->SmmLoadedImage > ); > if (!EFI_ERROR(Status)) { >=20 Reviewed-by: Philippe Mathieu-Daude