Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio

["Pete Batard via groups.io" <pete=akeo.ie@groups.io>]

Hi Ard,

Thanks for the quick review.

Note that as opposed to the previous one you referenced, that patches 
both the .S and the .asm, my submission only patches the .asm, so it's 
probably better to use Adam Liu's for integration (who was the first to 
propose a fix anyway).

As to your other question, see inline:

On 2024.05.08 10:08, Ard Biesheuvel wrote:
> On Wed, 8 May 2024 at 11:07, Ard Biesheuvel <ardb@kernel.org> wrote:
>>
>> On Wed, 8 May 2024 at 10:52, Pete Batard <pete@akeo.ie> wrote:
>>>
>>> Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression
>>> resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer'
>>> when compling MdePkg for AARCH64 with Visual Studio.
>>> Fix this by adding the relevant EXTERN reference.
>>>
>>> Signed-off-by: Pete Batard <pete@akeo.ie>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>
>> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>>
>> Note that the same issue has been raised two months ago, and a similar
>> fix proposed
>>
>> https://openfw.io/edk2-devel/20240320025130.599086-1-adam.liu@tw.synaptics.com/
>>
>> so IMHO this qualifies for inclusion in the stable tag.
>>
> 
> BTW the existence of this issue appears to imply that the VS RELEASE
> build does not #define MDEPKG_NDEBUG. Is that an oversight?

In my testing with VS2022 (with '-b RELEASE'), adding:

#ifdef MDEPKG_NDEBUG
#error MDEPKG_NDEBUG is defined
#endif

to SetJump.c does produce the expected:

d:\edk2\MdePkg\Library\BaseLib\SetJump.c(12): fatal error C1189: #error: 
  MDEPKG_NDEBUG is defined

So as far as I can tell, MDEPKG_NDEBUG is properly defined.

Regards,

/Pete

> 
>>
>>> ---
>>>   MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
>>> index 6ec8f35f2c9f..fa161e25f517 100644
>>> --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
>>> +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
>>> @@ -7,6 +7,7 @@
>>>
>>>     EXPORT SetJump
>>>     EXPORT InternalLongJump
>>> +  EXTERN InternalAssertJumpBuffer
>>>     AREA BaseLib_LowLevel, CODE, READONLY
>>>
>>>   #define GPR_LAYOUT                          \
>>> --
>>> 2.45.0.windows.1
>>>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118669): https://edk2.groups.io/g/devel/message/118669
Mute This Topic: https://groups.io/mt/105977470/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-