From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 374707803CC for ; Wed, 8 May 2024 09:21:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=l1RF2HzLAH/cIkr6DNzfLJauvlM2e7X8L6U+2c8iJNY=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715160066; v=1; b=CRN9rIxsPj1HJrSfj6pmvc2cu9lPIczwwVj9iyti/nNp2mlvT6rmeR5K92Oh91Cs3QFY/HYJ 7IhzBT71NptFh/rLp0a2jDfG9O5htnB3UhSjyiJXnWnDq44Ws8QQutbqmZHujsyp+ibk+zWdktH ALKmh9AQCMCRa64NyZ8F/FH4xIE5xuYslNVVIqzzaJ7CVuVmaXlA3y7cYkpSEzzuDM16o82g4Nt JHjn/Miibvk4eNBKVggYiWMxamQWwDHIKUfLpeqQKAn4i9wAbkxYkozlv0i50P0q4MTw+9I75yE xFEOD1I20ZrHG4DDRsQVf+BVrvqsPINY19F2fDGDPuDeA== X-Received: by 127.0.0.2 with SMTP id ZOpwYY7687511xGtqllNy4AX; Wed, 08 May 2024 02:21:06 -0700 X-Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mx.groups.io with SMTP id smtpd.web11.7835.1715160065299217400 for ; Wed, 08 May 2024 02:21:05 -0700 X-Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2e4939c5323so311381fa.2 for ; Wed, 08 May 2024 02:21:05 -0700 (PDT) X-Gm-Message-State: PKe0HR6EWDzkCb4sPg6tict8x7686176AA= X-Google-Smtp-Source: AGHT+IG00XYp65q6mb9bcVy725UQ5RBURFr85vROkPhsmmoZYJKvrAvUXSbt5quWWE1kohLezDl2AA== X-Received: by 2002:a2e:97c9:0:b0:2e3:ba0e:de12 with SMTP id 38308e7fff4ca-2e446e82769mr16868251fa.22.1715160063174; Wed, 08 May 2024 02:21:03 -0700 (PDT) X-Received: from [10.0.0.117] (ip-84-203-13-9.broadband.digiweb.ie. [84.203.13.9]) by smtp.gmail.com with ESMTPSA id n22-20020a05600c4f9600b0041bab13cd74sm1598122wmq.17.2024.05.08.02.21.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 May 2024 02:21:02 -0700 (PDT) Message-ID: Date: Wed, 8 May 2024 10:21:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio To: Ard Biesheuvel Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn References: <20240508085148.1725-1-pete@akeo.ie> <20240508085148.1725-2-pete@akeo.ie> From: "Pete Batard via groups.io" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 08 May 2024 02:21:05 -0700 Resent-From: pete@akeo.ie Reply-To: devel@edk2.groups.io,pete@akeo.ie List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=CRN9rIxs; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Ard, Thanks for the quick review. Note that as opposed to the previous one you referenced, that patches=20 both the .S and the .asm, my submission only patches the .asm, so it's=20 probably better to use Adam Liu's for integration (who was the first to=20 propose a fix anyway). As to your other question, see inline: On 2024.05.08 10:08, Ard Biesheuvel wrote: > On Wed, 8 May 2024 at 11:07, Ard Biesheuvel wrote: >> >> On Wed, 8 May 2024 at 10:52, Pete Batard wrote: >>> >>> Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression >>> resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer' >>> when compling MdePkg for AARCH64 with Visual Studio. >>> Fix this by adding the relevant EXTERN reference. >>> >>> Signed-off-by: Pete Batard >>> Cc: Leif Lindholm >>> Cc: Ard Biesheuvel >> >> Reviewed-by: Ard Biesheuvel >> >> Note that the same issue has been raised two months ago, and a similar >> fix proposed >> >> https://openfw.io/edk2-devel/20240320025130.599086-1-adam.liu@tw.synapti= cs.com/ >> >> so IMHO this qualifies for inclusion in the stable tag. >> >=20 > BTW the existence of this issue appears to imply that the VS RELEASE > build does not #define MDEPKG_NDEBUG. Is that an oversight? In my testing with VS2022 (with '-b RELEASE'), adding: #ifdef MDEPKG_NDEBUG #error MDEPKG_NDEBUG is defined #endif to SetJump.c does produce the expected: d:\edk2\MdePkg\Library\BaseLib\SetJump.c(12): fatal error C1189: #error:=20 MDEPKG_NDEBUG is defined So as far as I can tell, MDEPKG_NDEBUG is properly defined. Regards, /Pete >=20 >> >>> --- >>> MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePk= g/Library/BaseLib/AArch64/SetJumpLongJump.asm >>> index 6ec8f35f2c9f..fa161e25f517 100644 >>> --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm >>> +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm >>> @@ -7,6 +7,7 @@ >>> >>> EXPORT SetJump >>> EXPORT InternalLongJump >>> + EXTERN InternalAssertJumpBuffer >>> AREA BaseLib_LowLevel, CODE, READONLY >>> >>> #define GPR_LAYOUT \ >>> -- >>> 2.45.0.windows.1 >>> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118669): https://edk2.groups.io/g/devel/message/118669 Mute This Topic: https://groups.io/mt/105977470/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-