From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9B6AD740056 for ; Fri, 19 Jan 2024 13:55:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3iWe9G8asQTHBgC20l6wXEbJjEYTBuG6MuUwlw662m4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705672506; v=1; b=SK+GgZ5x5RYFnppoob1Z7eIlC9LH3LNPOB6PfATkVAVIJ1j8wG/5facisLD/oAMt2Ezez1qD qy+vbyer46hLsLcNm7c0s3wJNCpiR0YcW4+6xyf2D3+WwkvDJrRngq0Orq7Q+1rvi7TSB8vbwmf HIUPwFOyqM2kEzR80tX/pHHk= X-Received: by 127.0.0.2 with SMTP id NqafYY7687511xUW3J7tzNE1; Fri, 19 Jan 2024 05:55:06 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.22540.1705672505475697728 for ; Fri, 19 Jan 2024 05:55:05 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-YwiximRWMZexfuJ3nXvJXg-1; Fri, 19 Jan 2024 08:55:00 -0500 X-MC-Unique: YwiximRWMZexfuJ3nXvJXg-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E6A26185A780; Fri, 19 Jan 2024 13:54:59 +0000 (UTC) X-Received: from [10.39.192.76] (unknown [10.39.192.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C38E492BC6; Fri, 19 Jan 2024 13:54:59 +0000 (UTC) Message-ID: Date: Fri, 19 Jan 2024 14:54:58 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] Memory Attribute for depex section To: Nhi Pham , Ard Biesheuvel Cc: "Andrew (EFI) Fish" , edk2-devel-groups-io , "ardb+tianocore@kernel.org" References: <44ca139f-4d78-4322-b5b6-8e9788bb7486@os.amperecomputing.com> <2ad16043-754e-3bb9-3a4a-702d9a50bf63@redhat.com> <45b95719-f1fc-dbc6-a4cc-a022d691844c@redhat.com> <8d745268-263c-c99a-67c6-fe0fb6cd4b8e@redhat.com> <0e0b2e56-30dd-4f5f-9708-98690246efda@os.amperecomputing.com> <20d8728f-daaa-51ed-18ad-3087695d21f1@redhat.com> <8efe1653-7383-44a6-b820-efb1c6132f74@os.amperecomputing.com> <40d61bec-49c1-e560-7d6b-05c789b2b5f6@redhat.com> <6e09ed4a-53b0-45e1-a070-b4086986876b@os.amperecomputing.com> From: "Laszlo Ersek" In-Reply-To: <6e09ed4a-53b0-45e1-a070-b4086986876b@os.amperecomputing.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BvAOtkeFPlOyGqHYadJm5aj2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SK+GgZ5x; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/19/24 05:43, Nhi Pham wrote: > On 1/18/2024 9:49 PM, Laszlo Ersek wrote: >>>>> but I'd prefer to just remove this >>>>> optimization from standalone MM, given that not only a) it shouldn't >>>>> have to deal with a large number of protocol GUIDs, but also b) the >>>>> driver dispatch is much more straight-forward. (Typically, StMM >>>>> drivers can be dispatched in the order they appear in the firmware >>>>> volume, in which case each DEPEX is evaluated only once anyway) >>>> >>>> Sounds like a promising basis for removing the optimization indeed! >>>> >>> >>> Your patch suggested earlier works for me. And I don't see significant >>> performance reduction compared with keeping optimization. >>> >>> I don't have strong reason on removing the optimization, but I think it >>> would be simply good for now. Could you post your patch to edk2-devel >>> for review and merge? >> >> That wouldn't be correct; I don't have any platform for testing StMM. I >> proposed the patch purely based on code analysis. I prefer not to post >> untested patches, if I can avoid it. >=20 > I got it, thanks! >=20 > I thought I could give Tested-by tag when you post the patch since I > already verified the patch on a StMM platform Oh, that seems to have eluded me, sorry -- it's not uncommon that a patch submitter needs help with testing (external testing) on *some* platforms, beside his or her main platform(s) of interest. What's quite uncommon though is total untestability for the submitter; I admit I drew a blank there. What you mention would have been viable. Thank you for posting the patch, ultimately! Laszlo >=20 >> >> You can however post my patch; simply add your S-o-b at the bottom. You >> can also preserve my authorship on the patch with --author=3D... on >> git-commit; but even that is unnecessary for such a simple patch (you >> don't even have to pick the patch up from the email, it's trivial to >> reimplement from scratch, just reading the email). >=20 > I'm going to send the patch to edk2-devel and keep your authorship on > the patch because there is no change compared with your suggestion in > the email. >=20 > Thanks, > Nhi >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114048): https://edk2.groups.io/g/devel/message/114048 Mute This Topic: https://groups.io/mt/103594587/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-