Re: [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

["Dov Murik" <dovmurik@linux.ibm.com>]

On 19/07/2021 22:14, Dov Murik wrote:
> 
> 
> On 19/07/2021 18:21, Tom Lendacky wrote:
>> On 7/6/21 3:54 AM, Dov Murik wrote:
>>> From: James Bottomley <jejb@linux.ibm.com>
>>>
>>> Support QEMU's -kernel option.
>>>
>>> OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c is an exact copy
>>> of OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c .
>>
>> Just a nit, but this confused me initially. Maybe it should say something
>> along the lines of create a QemuKernel.c for PlatformBootManagerLibGrub
>> that is an exact copy of the file from PlatformBootManagerLib.
>>
> 
> You're right; I'll write it clearer.
> 
> 
>> Is there any way that the two libraries can use the same file rather than
>> making an exact copy?
> 
> I guess it's possible by extracting the file into its own library?  I'll
> need to take a deeper look.
> 


With this patch we'll have two identical files:

  OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c
  OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c

but there's another QemuKernel.c, which is *almost* identical:

  ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c

so a proper fix should consolidate all three into one library used by
all three libs.

I suggest postponing this to a separate refactoring series.

Thanks,
-Dov