From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web12.45111.1622472982679528862 for ; Mon, 31 May 2021 07:56:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SztdXTU2; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622472981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KEunjYoFmn/t4JsXAyfrokChmx7CMtgBZarYnK7o6rk=; b=SztdXTU2eYnmJx44Vw6CE8fPiQLd25RBciw9AaEu7lBVBKsI+vxMJy4BNn0YqJEYA9TRNN Ie4dexW/gguvOh4icJqPan4eq0FFOhUYHXYertmXoWqo7VMyR2TBQ10rd0oVHiJM53bdjM hGAEN5KMilGSzCnB7J42zcVJWzgxbz4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-uUbypbBlMxWi6PT7V5h0Og-1; Mon, 31 May 2021 10:56:20 -0400 X-MC-Unique: uUbypbBlMxWi6PT7V5h0Og-1 Received: by mail-wm1-f69.google.com with SMTP id w3-20020a1cf6030000b0290195fd5fd0f2so51516wmc.4 for ; Mon, 31 May 2021 07:56:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KEunjYoFmn/t4JsXAyfrokChmx7CMtgBZarYnK7o6rk=; b=Hbqw9YPeA23kLBQM1nOC8FXOGv3tVjVIWk8UxVehMDLHXholsufHWeIvKYOqSjxJ4W q4mYN7sU/tx/cCnYWXzBxqUZapIg7JIRK3hk0lmqPfGqEzxTNeRnpPD0Q32NWFRcGD/A qWQH7Zi/nXSj8qzyBMwJmXfUHDGVsRQlgdzZRw1rFCf+N0iiDHSX2P0ssHsVz562kM/7 XA2wvmkoJnTiKDmwmyTbFvXGYNNIJyekIKGjjenWfgUqTE+CFCx2dJ2D0Gt7+XzLnGAo H+/RqafzZTPO3RdU7YoYhtKzlLyz5fJpfovc5ehObLA4lSKcQT0NEbk5LHcrDiN7hcCh wDoQ== X-Gm-Message-State: AOAM531dw/QPocldCcHv/hZNcn4iD6aQGjvQRZq9RfgLFjSHWqBna/SD 4F4LN+Lj+vQFw7XlJlJ/I5yK7r5Hh5eyeX685K6EocOJ2TRHYMDthEZuuAQEF31RkTQoiTpRoHK /OqpLRgOZs5tdGw== X-Received: by 2002:a7b:c749:: with SMTP id w9mr8196852wmk.3.1622472979084; Mon, 31 May 2021 07:56:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSfMys8Hg4wsYGRQ8aSkHzbe7AMvLdq8d46l7mhyJANE7Fx08MIHjxiZjZBbnHFFTCFk9T3g== X-Received: by 2002:a7b:c749:: with SMTP id w9mr8196839wmk.3.1622472978939; Mon, 31 May 2021 07:56:18 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id r7sm14790050wmq.18.2021.05.31.07.56.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 May 2021 07:56:18 -0700 (PDT) Subject: Re: [PATCH 41/43] OvmfPkg/SmbiosPlatformDxe: create Xen-specific module INF file To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-42-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Mon, 31 May 2021 16:56:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-42-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > "OvmfPkg/SmbiosPlatformDxe" is structured somewhat differently from the > drivers duplicated and trimmed thus far in this series. The final QEMU and > Xen versions will share a relatively significant amount of code, therefore > duplicating the whole driver is less useful, even temporarily. Instead, > duplicate the INF file, in preparation for customizing the entry point > function. > > Because ArmVirtXen doesn't actually include OvmfPkg/SmbiosPlatformDxe [*], > there is only one platform that's supposed to consume the new driver: > OvmfXen. Switch OvmfXen to the new driver at once. > > [*] See commit 164cf4038357 ("OvmfPkg: SmbiosPlatformDxe: restrict current > Xen code to IA32/X64", 2015-07-26). > > This patch is best viewed with "git show --find-copies-harder". > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/OvmfXen.dsc | 2 +- > OvmfPkg/OvmfXen.fdf | 2 +- > OvmfPkg/SmbiosPlatformDxe/{SmbiosPlatformDxe.inf => XenSmbiosPlatformDxe.inf} | 7 ++++--- > 3 files changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daude