From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: Oliver Steffen <osteffen@redhat.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Bob Feng <bob.c.feng@intel.com>,
Daniel Schaefer <git@danielschaefer.me>,
Gerd Hoffmann <kraxel@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Sunil V L <sunilvl@ventanamicro.com>,
Yuwei Chen <yuwei.chen@intel.com>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Chris Fernald <chfernal@microsoft.com>
Subject: Re: [PATCH v9 10/12] .pytool: CISettings.py: don't add scopes for GCC
Date: Wed, 30 Nov 2022 19:02:21 -0500 [thread overview]
Message-ID: <c2f87f68-ce74-f01d-fb60-00f40eef72a6@linux.microsoft.com> (raw)
In-Reply-To: <CA+bRGFpO2_DXWiOHMfFUUK9kXg9jpRbvLROhHEHWZusmwqynCg@mail.gmail.com>
Not a big deal but I think it would be cleaner to remove the scopes in a
commit before the ext_dep files are actually removed.
For the changes in this patch:
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
On 11/30/2022 5:01 PM, Oliver Steffen wrote:
> All ext_dep.yml files for gcc have been removed and gcc
> is expected to be installed on the system (GCC5_*_PREFIX
> may indicate the location).
> No need to adjust the toolchain scopes for Linux builds
> anymore.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
> .pytool/CISettings.py | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
> index 76ac2b09dba6..d87c8e838e61 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -169,15 +169,6 @@ class Settings(CiBuildSettingsManager,
> UpdateSettingsManager, SetupSettingsManag
> else:
> logging.warning("Falling back to using in-tree BaseTools")
>
> - if is_linux and self.ActualToolChainTag.upper().startswith("GCC"):
> - if "AARCH64" in self.ActualArchitectures:
> - scopes += ("gcc_aarch64_linux",)
> - if "ARM" in self.ActualArchitectures:
> - scopes += ("gcc_arm_linux",)
> - if "RISCV64" in self.ActualArchitectures:
> - scopes += ("gcc_riscv64_unknown",)
> - if "LOONGARCH64" in self.ActualArchitectures:
> - scopes += ("gcc_loongarch64_unknown_linux",)
> self.ActualScopes = scopes
> return self.ActualScopes
>
next prev parent reply other threads:[~2022-12-01 0:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221130220125.1112760-1-osteffen@redhat.com>
2022-11-30 22:01 ` [PATCH v9 01/12] CI: make Python version configurable Oliver Steffen
2022-11-30 23:46 ` [edk2-devel] " Michael Kubacki
2022-11-30 22:01 ` [PATCH v9 02/12] OvmfPkg: CI: use Python version from defaults template Oliver Steffen
2022-12-01 0:04 ` [edk2-devel] " Michael Kubacki
2022-11-30 22:01 ` [PATCH v9 03/12] EmulatorPkg: " Oliver Steffen
2022-12-01 0:04 ` [edk2-devel] " Michael Kubacki
2022-11-30 22:01 ` [PATCH v9 04/12] CI: add ~/.local/bin to PATH (Linux only) Oliver Steffen
2022-12-01 0:05 ` [edk2-devel] " Michael Kubacki
2022-11-30 22:01 ` [PATCH v9 05/12] CI: Allow running in a container Oliver Steffen
2022-12-01 0:05 ` [edk2-devel] " Michael Kubacki
2022-11-30 22:01 ` [PATCH v9 06/12] BaseTools: CI: Use Fedora 35 container (Linux only) Oliver Steffen
2022-12-01 0:05 ` [edk2-devel] " Michael Kubacki
2022-11-30 22:01 ` [PATCH v9 07/12] ArmVirtPkg: " Oliver Steffen
2022-11-30 22:01 ` [PATCH v9 08/12] OvmfPkg: " Oliver Steffen
2022-11-30 22:01 ` [PATCH v9 09/12] EmulatorPkg: " Oliver Steffen
2022-11-30 22:01 ` [PATCH v9 10/12] .pytool: CISettings.py: don't add scopes for GCC Oliver Steffen
2022-12-01 0:02 ` Michael Kubacki [this message]
2022-11-30 22:01 ` [PATCH v9 11/12] CI: use latest vm_image (Linux only) Oliver Steffen
2022-11-30 23:41 ` Michael Kubacki
2022-12-01 0:03 ` Michael Kubacki
2022-11-30 22:01 ` [PATCH v9 12/12] do not merge: modify *.dsc to trigger CI Oliver Steffen
2022-11-30 22:04 ` Oliver Steffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2f87f68-ce74-f01d-fb60-00f40eef72a6@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox