From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3880A7803D9 for ; Wed, 28 Feb 2024 11:30:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=M/4TEc7hLU3Wlc5eZmHxFc2sZpYdl8cjaepwo6imRaU=; c=relaxed/simple; d=groups.io; h=Date:From:To:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1709119798; v=1; b=NaPpTAJQA9cCRm7L4FUdEIN/6jYp587gTD9Ki6cDE1hXkN25fJSgG1QpeYQTggdbRtos2jvp t2Wx4+A404Rb5mmNY/f9/2lBrWFQS71J8KV1dSMt+Cjvkl/7BgXfM1raO1OfaO+f9KWWQPWCpJJ HvSdFBUW2JI6jnTebX+7OyYk= X-Received: by 127.0.0.2 with SMTP id EnNyYY7687511xE9NJGK8o1d; Wed, 28 Feb 2024 03:29:58 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.10894.1709119796929750590 for ; Wed, 28 Feb 2024 03:29:57 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-huHwjTL-MqiLCddQY0tJzA-1; Wed, 28 Feb 2024 06:29:54 -0500 X-MC-Unique: huHwjTL-MqiLCddQY0tJzA-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 659421C0513F; Wed, 28 Feb 2024 11:29:54 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40C2BF63F3; Wed, 28 Feb 2024 11:29:54 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0143A1801480; Wed, 28 Feb 2024 12:29:52 +0100 (CET) Date: Wed, 28 Feb 2024 12:29:52 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, mikuback@linux.microsoft.com Subject: Re: [edk2-devel] CodeQL Analysis in edk2 Message-ID: References: <80abb140-9a9c-43b8-ba0b-d8ea631d9051@linux.microsoft.com> MIME-Version: 1.0 In-Reply-To: <80abb140-9a9c-43b8-ba0b-d8ea631d9051@linux.microsoft.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: SAkTdR4ZMSKU3dJEwgFKkfVex7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NaPpTAJQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Feb 27, 2024 at 11:04:47AM -0500, Michael Kubacki wrote: > Hi Gerd, > > A real-world example is here: https://github.com/microsoft/mu_basecore/blob/release/202311/CodeQlFilters.yml > > That can currently operate at the file and CodeQL rule level granularity. In > this case, the null pointer test rule ("cpp/missing-null-test" as shown in > https://github.com/tianocore/edk2/security/code-scanning/1277) could be > excluded in MpLib.c. CodeQL apparently has support for assertions[1]. The documentation sounds like this can be extended. So maybe it is possible to add an 'Edk2Assert' class, to have CodeQL recognize ASSERT() + variants in the edk2 source code? That should reduce the number of filter rules needed and simplify maintenance long-term. take care, Gerd [1] https://codeql.github.com/codeql-standard-libraries/cpp/semmle/code/cpp/commons/Assertions.qll/module.Assertions.html -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116112): https://edk2.groups.io/g/devel/message/116112 Mute This Topic: https://groups.io/mt/102444916/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-