Re: [PATCH edk2-platforms v2 12/43] Platform/Hisilicon/D06: Add edk2-non-osi components for D06

[Ming <ming.huang@linaro.org>]

On 8/22/2018 5:49 PM, Leif Lindholm wrote:
> On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote:
>> Add PcdCoreCount to fix build issue while add binary components.
> 
> This commit message fails to describe what is being done, apart from a
> single thing that should be a separate patch.
> 
> Pleas add a proper commit message describing which components are
> being imported.
> 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang <ming.huang@linaro.org>
>> ---
>>  Platform/Hisilicon/D06/D06.dsc                                                 |  7 +++++++
>>  Platform/Hisilicon/D06/D06.fdf                                                 | 17 +++++++++++++++++
>>  Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf |  2 ++
>>  3 files changed, 26 insertions(+)
>>
> 
>> diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
>> index 2275586ff3..a47806f391 100644
>> --- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
>> +++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
>> @@ -28,6 +28,7 @@
>>  
>>  [Packages]
>>    ArmPkg/ArmPkg.dec
>> +  ArmPlatformPkg/ArmPlatformPkg.dec
>>    MdePkg/MdePkg.dec
>>    MdeModulePkg/MdeModulePkg.dec
>>    IntelFrameworkPkg/IntelFrameworkPkg.dec
>> @@ -52,6 +53,7 @@
>>    gEfiSmbiosProtocolGuid                       # PROTOCOL ALWAYS_CONSUMED
>>  
>>  [Pcd]
>> +  gArmPlatformTokenSpaceGuid.PcdCoreCount
>>    gHisiTokenSpaceGuid.PcdCPUInfo
>>    gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
> 
> And please submit this as a separate patch, explaining why the change
> is needed. If it is only needed by one of the binary modules imported
> as part of the current patch, place it immediately preceding this.
> 
> If it resolves some other issue, please insert it as early in the set
> as possible.

Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620 add a function
which use the PcdCoreCount and the function is used by ProcessorSubClassDxe.
Should I add gArmPlatformTokenSpaceGuid.PcdCoreCount to
Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf ?
And delete the commit message in this patch ?

> 
> /
>     Leif
> 
>>  
>> -- 
>> 2.17.0
>>