From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::241; helo=mail-pl0-x241.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x241.google.com (mail-pl0-x241.google.com [IPv6:2607:f8b0:400e:c01::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B2704210FBEE5 for ; Wed, 22 Aug 2018 07:55:20 -0700 (PDT) Received: by mail-pl0-x241.google.com with SMTP id ba4-v6so972337plb.11 for ; Wed, 22 Aug 2018 07:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dXUaHbXgrlmxuNh5SWzzGYAs9G11dT5IrwREhHgRvFs=; b=OfHTyIvqYXIOSSv9mwmH2DdqzlSghZ2yPnJSIuG03Z6t+kDch4tB4Rnp2Z7e5RNnUY 1kcfnZGM2d0IfGoUXcPaowy37CWXubC/JrutjxH902lF/I/8SYHQ8wXcqTRGOzoGiPR/ k0kY1F88uc4BYuSOhmf93SZEJduyHq5EkqBSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dXUaHbXgrlmxuNh5SWzzGYAs9G11dT5IrwREhHgRvFs=; b=bI81m3Ejq1SS5NjC2Qgp/XJQoex5NFSRGOTOVIgzUett6Ak33BH8XP3lYJ9RgMHWx9 3CWl26Ivc2Zf+pnMvRDKgYrJpWrpQ7Mr5G1Y5h1mBc86VPRdA1uir6SM4y8CC65Y+qY7 h4utftfxtnuKl7xb2oNZ3UlAjsVNldzBhxD5lg1ok1LKc4r0OdxMcGeKHt7GN5NgKSo9 sZ78fYLUZFXZBuc+PPEwQzSy86yOpEpd4AV0NykHA+PErvrB0aD32Q/gZup5KJ7vfhb1 87oPi9uV24JLpZQpUA2ldRQOWaPKx1fYECk7+YP3Y7da5mVGmNaYyDj2Fnykvr7NJnoF xYNw== X-Gm-Message-State: AOUpUlGETXG/8GaPGlJZXfx/9Gy/KfscOWro0vVPyzxYIjUivH4iPNQo N0HpysX58LjLT9wpQjn8ID6OvA== X-Google-Smtp-Source: AA+uWPzyMnXX0rwmBpyjTQLdkE7VXYVEtRFIqx6ZgwKmxWLBbDl9dZX6qHFIlJ5UATdjK3mJQSWR4A== X-Received: by 2002:a17:902:14e:: with SMTP id 72-v6mr54005438plb.299.1534949719978; Wed, 22 Aug 2018 07:55:19 -0700 (PDT) Received: from [10.84.0.214] ([64.64.108.140]) by smtp.gmail.com with ESMTPSA id w81-v6sm5362253pfk.92.2018.08.22.07.55.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Aug 2018 07:55:19 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-13-ming.huang@linaro.org> <20180822094901.6oavgeeqpzckqjwx@bivouac.eciton.net> From: Ming Message-ID: Date: Wed, 22 Aug 2018 22:54:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180822094901.6oavgeeqpzckqjwx@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v2 12/43] Platform/Hisilicon/D06: Add edk2-non-osi components for D06 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 14:55:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/22/2018 5:49 PM, Leif Lindholm wrote: > On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote: >> Add PcdCoreCount to fix build issue while add binary components. > > This commit message fails to describe what is being done, apart from a > single thing that should be a separate patch. > > Pleas add a proper commit message describing which components are > being imported. > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Platform/Hisilicon/D06/D06.dsc | 7 +++++++ >> Platform/Hisilicon/D06/D06.fdf | 17 +++++++++++++++++ >> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 2 ++ >> 3 files changed, 26 insertions(+) >> > >> diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf >> index 2275586ff3..a47806f391 100644 >> --- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf >> +++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf >> @@ -28,6 +28,7 @@ >> >> [Packages] >> ArmPkg/ArmPkg.dec >> + ArmPlatformPkg/ArmPlatformPkg.dec >> MdePkg/MdePkg.dec >> MdeModulePkg/MdeModulePkg.dec >> IntelFrameworkPkg/IntelFrameworkPkg.dec >> @@ -52,6 +53,7 @@ >> gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED >> >> [Pcd] >> + gArmPlatformTokenSpaceGuid.PcdCoreCount >> gHisiTokenSpaceGuid.PcdCPUInfo >> gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz > > And please submit this as a separate patch, explaining why the change > is needed. If it is only needed by one of the binary modules imported > as part of the current patch, place it immediately preceding this. > > If it resolves some other issue, please insert it as early in the set > as possible. Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620 add a function which use the PcdCoreCount and the function is used by ProcessorSubClassDxe. Should I add gArmPlatformTokenSpaceGuid.PcdCoreCount to Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf ? And delete the commit message in this patch ? > > / > Leif > >> >> -- >> 2.17.0 >>