From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mx.groups.io with SMTP id smtpd.web10.7603.1681474618507331545 for ; Fri, 14 Apr 2023 05:16:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=rc7v0OH3; spf=pass (domain: bsdio.com, ip: 64.147.123.25, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7F0EF3200312; Fri, 14 Apr 2023 08:16:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 14 Apr 2023 08:16:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681474616; x=1681561016; bh=rbFbw68sSQ58tfOb/LZU358+vGg1kOpLzEU PeEBQDnk=; b=rc7v0OH34YR1xXx4dMVmiKfSMKVpyKOvafDYRkDVDvt/XOOHsAv IPHewWtG4HJ1HmQ3huS8SHgyP1Hra5hBw9OusM+aq8v1v1e7c1QCHyXbQuNOeQeX VkhrKKoxKMGvhkWJxRC6UT0KqIxQScMf6Jvid6xANYKwIXBUPEqZguZJ1JrRhyIK 5TdjYCa4QaKbDjF1fp2BtBsfZ3Mt188XD16/Msmnq+k2Wa7n4Jj0QVw4U7/18axH R5SLfTY0T5Ft2C1jaNZX/PmMU67t+7zELJ8lHHaBTH7guU8Y/vp4WEVnqLEW2lVh pxQSczc1TPrf+H8QjxPKjhIJzmjPiqUxUZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681474616; x=1681561016; bh=rbFbw68sSQ58tfOb/LZU358+vGg1kOpLzEU PeEBQDnk=; b=Db5ocj6PAhFPjVpY3JHzXNYBI8SYqExXKIMA9GtNKTfleD3OA9W 3a/5Gk8Gc5BJOrMs/mZpOxlseEZACF8flmBTErpxK995v0Xh1In6X8bJBce/01+6 +C1XrCE4Se8wr6HCq4B3p8t6rw6+t0n++rbKME8UIC3jvb+fyhSHO2878oujpJsu /pVCOs/bKGaHrvAADDRwovR8hMhCrrPefFScm3qIeeSgd33GvruKP2PyS/q/qVBs 719IW651ydcuP26EZ4QocwRFUAGuGQZqJh0tfM84cdqA94Spo2qHZ6x/MKcumdQV 9mquKn3uvhUtLMpMIizxc4x3d3kyJUjf5GA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeltddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Apr 2023 08:16:53 -0400 (EDT) Message-ID: Date: Fri, 14 Apr 2023 06:16:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH v4 08/10] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_* To: devel@edk2.groups.io, kraxel@redhat.com Cc: Pawel Polawski , Dongyan Qian , Sunil V L , Baoqi Zhang , Chao Li , Ard Biesheuvel , Zhiguang Liu , Liming Gao , Yuwei Chen , =?UTF-8?Q?Marvin_H=c3=a4user?= , Leif Lindholm , Michael D Kinney , Daniel Schaefer , Bob Feng , Oliver Steffen References: <20230414080250.1357004-1-kraxel@redhat.com> <20230414080250.1357004-9-kraxel@redhat.com> From: "Rebecca Cran" In-Reply-To: <20230414080250.1357004-9-kraxel@redhat.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/14/23 02:02, Gerd Hoffmann wrote: > diff --git a/BaseTools/Source/C/Include/IndustryStandard/PeImage.h b/BaseTools/Source/C/Include/IndustryStandard/PeImage.h > index 22161edf443d..fb867b5660a9 100644 > --- a/BaseTools/Source/C/Include/IndustryStandard/PeImage.h > +++ b/BaseTools/Source/C/Include/IndustryStandard/PeImage.h > @@ -42,6 +42,7 @@ > #define IMAGE_FILE_MACHINE_X64 0x8664 > #define IMAGE_FILE_MACHINE_ARM 0x01c0 // Thumb only > #define IMAGE_FILE_MACHINE_ARMT 0x01c2 // 32bit Mixed ARM and Thumb/Thumb 2 Little Endian > +#define IMAGE_FILE_MACHINE_ARMTHUMB_MIXED IMAGE_FILE_MACHINE_ARMT > #define IMAGE_FILE_MACHINE_ARM64 0xAA64 // 64bit ARM Architecture, Little Endian > #define IMAGE_FILE_MACHINE_RISCV64 0x5064 // 64bit RISC-V ISA > #define IMAGE_FILE_MACHINE_LOONGARCH64 0x6264 // 64bit LoongArch Architecture Has this passed CI/uncrustify? I think it would complain about the alignment here. -- Rebecca Cran