From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.11559.1683707641953094100
 for <devel@edk2.groups.io>;
 Wed, 10 May 2023 01:34:02 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BbjzACPR;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1683707641;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9UToUV54bFWV1abfCX/SMDBCkc7KwLyjupSLg4RP5M0=;
	b=BbjzACPRA4QsOu2IkvUF1WSuWwAKi6/QIs+2YTx45tBujjqIknpWoqMNOFzUVjnVt/xpZj
	Rsld4pOda0A52GxJmZg1YbBDlLBkSgF7lMp7f2Gbmc2WbCgnW98as95bhQ0SofUx86G0Kd
	qWEFuid+AVk5ZITc2OHKVgn+3dORx3M=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-32-2Y9-3b0iO7CeW4oynpyhHg-1; Wed, 10 May 2023 04:33:57 -0400
X-MC-Unique: 2Y9-3b0iO7CeW4oynpyhHg-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 63C553C0F688;
	Wed, 10 May 2023 08:33:57 +0000 (UTC)
Received: from [10.39.192.106] (unknown [10.39.192.106])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 46AEC2166B29;
	Wed, 10 May 2023 08:33:56 +0000 (UTC)
Message-ID: <c3416204-8ebb-32a5-1220-d796bd4791ff@redhat.com>
Date: Wed, 10 May 2023 10:33:55 +0200
MIME-Version: 1.0
Subject: Re: [PATCH v2 03/12] MdeModulePkg/SataControllerDxe: Remove useless null check
To: Pedro Falcato <pedro.falcato@gmail.com>, devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>, Liming Gao
 <gaoliming@byosoft.com.cn>, Hao A Wu <hao.a.wu@intel.com>,
 Ray Ni <ray.ni@intel.com>, Mike Maslenkin <mike.maslenkin@gmail.com>
References: <20230509163212.291333-1-pedro.falcato@gmail.com>
 <20230509163212.291333-4-pedro.falcato@gmail.com>
From: "Laszlo Ersek" <lersek@redhat.com>
In-Reply-To: <20230509163212.291333-4-pedro.falcato@gmail.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 5/9/23 18:32, Pedro Falcato wrote:
> ASSERT (Private != NULL) already covers this check.
> See commit 81310a6.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
>  .../Pci/SataControllerDxe/SataController.c    | 44 +++++++++----------
>  1 file changed, 21 insertions(+), 23 deletions(-)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>