From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.4860.1581389698707791285 for ; Mon, 10 Feb 2020 18:54:58 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: zhichao.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2020 18:54:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,427,1574150400"; d="scan'208";a="227372986" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 10 Feb 2020 18:54:57 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 10 Feb 2020 18:54:56 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Feb 2020 10:54:37 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Tue, 11 Feb 2020 10:54:37 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "ashishsingha@nvidia.com" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Topic: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Index: AQHVz1S5ttTJJxpElEylwh7oCb4WnKfzKyOggAsekwCABgclcIAP/G4AgAEg/FA= Date: Tue, 11 Feb 2020 02:54:37 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGJhMWFlZTItYWQyYi00ZjNmLWExZDEtMDFhZGJjNDQyOTVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQVdPeG5rU3hha25pN0kxVUNlRkl1VENOeWt3VG4rZzYxa3luSGVKcFwvdFN6cE1JNFBVbzVoTDliaElVRERUXC82In0= dlp-reaction: no-action dlp-version: 11.2.0.6 msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ashishsingha@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-02-10T17:39:20.5462936Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=bcdce489-c8a6-499c-aa20-247f4d792d7d; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The patch is already merged in the trunk. 66360134f8049cc70765cd3f119a5e2be= 2b67aa4 Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ashish > Singhal > Sent: Tuesday, February 11, 2020 1:39 AM > To: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray > > Subject: Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: = Fix > FADT Parser >=20 > Hello Ray, >=20 > Any update on this one? >=20 > Thanks > Ashish >=20 > -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, January 30, 2020 10:33 PM > To: Ashish Singhal ; devel@edk2.groups.io; Ni, = Ray > > Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: = Fix > FADT Parser >=20 > External email: Use caution opening links or attachments >=20 >=20 > Actually I have no permission to create the pull request. I would help t= o send the > patch to Ray and he would create the pull request. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > > Sent: Tuesday, January 28, 2020 1:29 AM > > To: Gao, Zhichao ; devel@edk2.groups.io; Ni, > > Ray > > Subject: RE: [edk2-devel] [PATCH] > > ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser > > > > Hello Zhichao, > > > > Do you know by when this may be merged? > > > > Thanks > > Ashish > > > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Monday, January 20, 2020 12:42 AM > > To: devel@edk2.groups.io; Ashish Singhal ; > > Ni, Ray > > Subject: RE: [edk2-devel] [PATCH] > > ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser > > > > External email: Use caution opening links or attachments > > > > > > Reviewed-by: Zhichao Gao > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > > Of Ashish Singhal > > > Sent: Monday, January 20, 2020 1:45 PM > > > To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao > > > > > > Cc: Ashish Singhal > > > Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: > > > Fix FADT Parser > > > > > > FADT parser was checking for reduced ACPI flag incorrectly leading > > > to incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are > > > both 0. > > > > > > Signed-off-by: Ashish Singhal > > > --- > > > .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2= +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars= er. > > > c > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars= er. > > > c > > > index 5b8cc174f1..8acfbac3b1 100644 > > > --- > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars= er. > > > c > > > +++ > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars > > > +++ er.c > > > @@ -253,7 +253,7 @@ ParseAcpiFadt ( > > > // present. > > > if ((Trace) && > > > (Flags !=3D NULL) && > > > - ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D 0)) { > > > + ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D > > > + EFI_ACPI_6_3_HW_REDUCED_ACPI)) { > > > IncrementErrorCount (); > > > Print (L"ERROR: No FACS table found, " > > > L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are > > > zero.\n"); > > > -- > > > 2.17.1 > > > > > > > > > > > > > ---------------------------------------------------------------------- > > ------------- This email message is for the sole use of the intended > > recipient(s) and may contain confidential information. Any > > unauthorized review, use, disclosure or distribution is prohibited. > > If you are not the intended recipient, please contact the sender by > > reply email and destroy all copies of the original message. > > ---------------------------------------------------------------------- > > ------------- >=20 >=20