public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kun Qin" <kuqin12@gmail.com>
To: Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Sean Brogan <spbrogan@outlook.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters
Date: Tue, 15 Jun 2021 10:04:45 -0700	[thread overview]
Message-ID: <c35ab480-3ac6-6117-2f85-34df90c094f2@gmail.com> (raw)
In-Reply-To: <MW4PR21MB1907B10CA0867EE2E21D1573EF309@MW4PR21MB1907.namprd21.prod.outlook.com>

Thanks for the review. Updated patch has been sent here: 
https://edk2.groups.io/g/devel/message/76553.

Please let me know if any other feedbacks.

Regards,
Kun

On 06/15/2021 09:20, Bret Barkelew wrote:
> Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
> 
> - Bret
> 
> *From: *Sean Brogan <mailto:spbrogan@outlook.com>
> *Sent: *Tuesday, June 15, 2021 9:00 AM
> *To: *devel@edk2.groups.io <mailto:devel@edk2.groups.io>; 
> kuqin12@gmail.com <mailto:kuqin12@gmail.com>
> *Cc: *Sean Brogan <mailto:sean.brogan@microsoft.com>; Bret Barkelew 
> <mailto:Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <mailto:michael.d.kinney@intel.com>; Liming Gao 
> <mailto:gaoliming@byosoft.com.cn>
> *Subject: *[EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: 
> SpellCheck: Defer path expansion in cspell parameters
> 
> Please update the signed-off-by to include yours.
> 
> Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
> 
> Thanks
> Sean
> 
> 
> On 6/11/2021 10:04 PM, Kun Qin wrote:
>  > From: Sean Brogan <sean.brogan@microsoft.com>
>  >
>  > REF: 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3454&amp;data=04%7C01%7CBret.Barkelew%40microsoft.com%7C436f445e3f774d2549b608d930169d05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637593696216659744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=pJiLG4bZ8gYR0MjDuNTmuT3NgRjq%2FZRMnTi1sT67VqM%3D&amp;reserved=0 
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3454&amp;data=04%7C01%7CBret.Barkelew%40microsoft.com%7C436f445e3f774d2549b608d930169d05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637593696216659744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=pJiLG4bZ8gYR0MjDuNTmuT3NgRjq%2FZRMnTi1sT67VqM%3D&amp;reserved=0>
>  >
>  > On Linux the shell expands the wildcard paths and causes multiple files
>  > to be missed. This change adds additional quotes to defer expansion in
>  > order to bring parity in cspell result.
>  >
>  > Cc: Sean Brogan <sean.brogan@microsoft.com>
>  > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>  > Cc: Michael D Kinney <michael.d.kinney@intel.com>
>  > Cc: Liming Gao <gaoliming@byosoft.com.cn>
>  >
>  > Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
>  > ---
>  >   .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++-
>  >   1 file changed, 2 insertions(+), 1 deletion(-)
>  >
>  > diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py 
> b/.pytool/Plugin/SpellCheck/SpellCheck.py
>  > index 43365441b91c..97b240ef747c 100644
>  > --- a/.pytool/Plugin/SpellCheck/SpellCheck.py
>  > +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py
>  > @@ -133,7 +133,8 @@ class SpellCheck(ICiBuildPlugin):
>  >           #
>  >           relpath = os.path.relpath(abs_pkg_path)
>  >           cpsell_paths = " ".join(
>  > -            [f"{relpath}/**/{x}" for x in 
> package_relative_paths_to_spell_check])
>  > +            # Double quote each path to defer expansion to cspell 
> parameters
>  > +            [f'"{relpath}/**/{x}"' for x in 
> package_relative_paths_to_spell_check])
>  >
>  >           # Make the config file
>  >           config_file_path = os.path.join(
>  >
> 

      reply	other threads:[~2021-06-15 17:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12  5:04 [PATCH v1 0/1] SpellCheck plugin inspects fewer files when run on Linux Kun Qin
2021-06-12  5:04 ` [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters Kun Qin
2021-06-15 15:59   ` [edk2-devel] " Sean
2021-06-15 16:20     ` [EXTERNAL] " Bret Barkelew
2021-06-15 17:04       ` Kun Qin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c35ab480-3ac6-6117-2f85-34df90c094f2@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox