From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mx.groups.io with SMTP id smtpd.web12.505.1623776687721434673 for ; Tue, 15 Jun 2021 10:04:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AIjtBSch; spf=pass (domain: gmail.com, ip: 209.85.215.177, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f177.google.com with SMTP id e20so12027320pgg.0 for ; Tue, 15 Jun 2021 10:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=os/NNeumIgNuqgwnLqqAITIu9sQpreSpebK4EJNZYKY=; b=AIjtBSch2jTuIlsZ+7QwE20MD6WVgeKrY9T15I5UsklpWymLyJxDEl3k5fdvjwkOlS IxWwd3b4LuYGjoE1NWVcbAFuf5ailkVU3nTZrSAjDlEWfOSkDZkDHif2oW5TR5pZ1i5o GVeD9am/dNB+rMfuvWH+jRYHzGmPs9e77U3XFvPvM5aYeUp/S3b0yOMstBfFsq8/fGym hV0V7sUF3xBn7kmdo0ruPJUrjAbnB7DYqffl0nPPZm4lQyWPqB3tJ9T+Q4POjylcYOTi o99enFUtB++2jn4XaPaNYvoOP4hnq13E51Gi9q/Gx4iTwkA+1U0r7lB9a+UM216u+M+U 694g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=os/NNeumIgNuqgwnLqqAITIu9sQpreSpebK4EJNZYKY=; b=Xo4t0FgGqGXMnufH4PC5KqJc0Dr36KEXVeoF+MPIQVn+JjiMvPiytQhGHobIjxk4dB nYCPwAB8cIFIadeHEktQAl9CPwImngXiqRniYgMfIgdm7D+EQoFoDHtSrK/4dyGyTDj9 KWhCKnDlMCieComwkbtUCtRYryOYXiQWWMHQy2o838V0y9ZIdZqJXDJfMSz/PI8t4ITG 4EekdBGj78J2JOzLNXGBeYf9Ttozij3IQwZNizx3X7lRKI8xCgZIRONlHLj1PVcWDpwX xMsl1cypcjErffFUWsnv368ePeHEUZ/D9xcADhVS1A9QnKZmu4/wfT3OltH7sFJudc9q zWeg== X-Gm-Message-State: AOAM531EzMWoPTKdYk3nLTT1j/BF2NtZsD7LeepidC8f5Y9hNZ16i3se h4j9KqoZDltdWkxnIpZyVwQ= X-Google-Smtp-Source: ABdhPJylCZKd2dFULSCiufLZYLqdgtEmJBFghyrE2DyGw2Ua/RLHGsAVSgI5G5JH4IaGKAACoI42xw== X-Received: by 2002:a62:7cca:0:b029:2e9:c89d:d8a9 with SMTP id x193-20020a627cca0000b02902e9c89dd8a9mr5107801pfc.55.1623776687216; Tue, 15 Jun 2021 10:04:47 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id c21sm15890278pfi.44.2021.06.15.10.04.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jun 2021 10:04:46 -0700 (PDT) Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters To: Bret Barkelew , Sean Brogan , "devel@edk2.groups.io" Cc: Sean Brogan , "Kinney, Michael D" , Liming Gao References: <20210612050431.660-1-kuqin12@gmail.com> <20210612050431.660-2-kuqin12@gmail.com> From: "Kun Qin" Message-ID: Date: Tue, 15 Jun 2021 10:04:45 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Thanks for the review. Updated patch has been sent here: https://edk2.groups.io/g/devel/message/76553. Please let me know if any other feedbacks. Regards, Kun On 06/15/2021 09:20, Bret Barkelew wrote: > Reviewed-by: Bret Barkelew > > - Bret > > *From: *Sean Brogan > *Sent: *Tuesday, June 15, 2021 9:00 AM > *To: *devel@edk2.groups.io ; > kuqin12@gmail.com > *Cc: *Sean Brogan ; Bret Barkelew > ; Kinney, Michael D > ; Liming Gao > > *Subject: *[EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: > SpellCheck: Defer path expansion in cspell parameters > > Please update the signed-off-by to include yours. > > Reviewed-by: Sean Brogan > > Thanks > Sean > > > On 6/11/2021 10:04 PM, Kun Qin wrote: > > From: Sean Brogan > > > > REF: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3454&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C436f445e3f774d2549b608d930169d05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637593696216659744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pJiLG4bZ8gYR0MjDuNTmuT3NgRjq%2FZRMnTi1sT67VqM%3D&reserved=0 > > > > > On Linux the shell expands the wildcard paths and causes multiple files > > to be missed. This change adds additional quotes to defer expansion in > > order to bring parity in cspell result. > > > > Cc: Sean Brogan > > Cc: Bret Barkelew > > Cc: Michael D Kinney > > Cc: Liming Gao > > > > Signed-off-by: Sean Brogan > > --- > >   .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++- > >   1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py > b/.pytool/Plugin/SpellCheck/SpellCheck.py > > index 43365441b91c..97b240ef747c 100644 > > --- a/.pytool/Plugin/SpellCheck/SpellCheck.py > > +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py > > @@ -133,7 +133,8 @@ class SpellCheck(ICiBuildPlugin): > >           # > >           relpath = os.path.relpath(abs_pkg_path) > >           cpsell_paths = " ".join( > > -            [f"{relpath}/**/{x}" for x in > package_relative_paths_to_spell_check]) > > +            # Double quote each path to defer expansion to cspell > parameters > > +            [f'"{relpath}/**/{x}"' for x in > package_relative_paths_to_spell_check]) > > > >           # Make the config file > >           config_file_path = os.path.join( > > >