Re: [edk2-devel] [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() parameter list

["Laszlo Ersek" <lersek@redhat.com>]

Jiaxin, Siyuan,

can you please review this patch?

Thanks
Laszlo


On 09/17/19 21:49, Laszlo Ersek wrote:
> The SockFreeFoo() callback function for NetbufFromExt() has to match the
> NET_VECTOR_EXT_FREE prototype, which takes a (VOID*) as callback argument
> (Arg). EFI_EVENT has nothing to do with NET_VECTOR_EXT_FREE. Fix the
> SockFreeFoo() parameter list.
> 
> This change is a no-op in practice.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     build-tested only
> 
>  NetworkPkg/TcpDxe/SockImpl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/NetworkPkg/TcpDxe/SockImpl.c b/NetworkPkg/TcpDxe/SockImpl.c
> index f5e01771e2a8..fb28e2ed40d3 100644
> --- a/NetworkPkg/TcpDxe/SockImpl.c
> +++ b/NetworkPkg/TcpDxe/SockImpl.c
> @@ -67,13 +67,13 @@ SockBufNext (
>  /**
>    User provided callback function for NetbufFromExt.
>  
> -  @param[in] Event    The Event this notify function registered to, ignored.
> +  @param[in] Arg      The Arg parameter forwarded by NetbufFromExt(). Ignored.
>  
>  **/
>  VOID
>  EFIAPI
>  SockFreeFoo (
> -  IN EFI_EVENT Event
> +  IN VOID      *Arg
>    )
>  {
>    return;
>