From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 26 Sep 2019 05:14:58 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 91BE01895A44; Thu, 26 Sep 2019 12:14:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-49.rdu2.redhat.com [10.10.120.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id C67AB1001938; Thu, 26 Sep 2019 12:14:57 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() parameter list From: "Laszlo Ersek" To: Jiaxin Wu , Siyuan Fu Cc: edk2-devel-groups-io Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-22-lersek@redhat.com> Message-ID: Date: Thu, 26 Sep 2019 14:14:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-22-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Thu, 26 Sep 2019 12:14:58 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Jiaxin, Siyuan, can you please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > The SockFreeFoo() callback function for NetbufFromExt() has to match the > NET_VECTOR_EXT_FREE prototype, which takes a (VOID*) as callback argument > (Arg). EFI_EVENT has nothing to do with NET_VECTOR_EXT_FREE. Fix the > SockFreeFoo() parameter list. > > This change is a no-op in practice. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > NetworkPkg/TcpDxe/SockImpl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NetworkPkg/TcpDxe/SockImpl.c b/NetworkPkg/TcpDxe/SockImpl.c > index f5e01771e2a8..fb28e2ed40d3 100644 > --- a/NetworkPkg/TcpDxe/SockImpl.c > +++ b/NetworkPkg/TcpDxe/SockImpl.c > @@ -67,13 +67,13 @@ SockBufNext ( > /** > User provided callback function for NetbufFromExt. > > - @param[in] Event The Event this notify function registered to, ignored. > + @param[in] Arg The Arg parameter forwarded by NetbufFromExt(). Ignored. > > **/ > VOID > EFIAPI > SockFreeFoo ( > - IN EFI_EVENT Event > + IN VOID *Arg > ) > { > return; >