Re: [edk2-platforms][PATCH v1 06/10] RaspberryPi: Add VariableFlashInfoLib

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Thanks for testing it.

On 4/22/2022 10:41 AM, Jeremy Linton wrote:
> Hi,
> 
> On 4/20/22 15:44, mikuback@linux.microsoft.com wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>
>> Adds an instance for the library class VariableFlashInfoLib that
>> was recently introduced in MdeModulePkg. This change is made to
>> allow the new variable driver to build that has a dependency on
>> this library class and does not require any further platform
>> changes.
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Jeremy Linton <jeremy.linton@arm.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>>   Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
>>   Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc 
>> b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> index 6dc48dc23302..0eed03c097f8 100644
>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> @@ -174,6 +174,7 @@ [LibraryClasses.common]
>>     
>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf 
>>
>>   !endif
>>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>> +  
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf 
>>
>>     
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf 
>>
>>     
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf 
>>
>>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc 
>> b/Platform/RaspberryPi/RPi4/RPi4.dsc
>> index a9c0c36bb12b..eabddd7382cf 100644
>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
>> @@ -174,6 +174,7 @@ [LibraryClasses.common]
>>     
>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf 
>>
>>   !endif
>>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>> +  
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf 
>>
>>     
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf 
>>
>>     
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf 
>>
>>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
> 
> I applied both this and the other required set, built and booted them, 
> and the variable store appears to continue behaving as before (both 
> with/without my SPI flash patches).
> 
> And this looks fairly trivial, I'm not sure why its not just picked up 
> as part of one of the other variable store related .inf's but <shrug>
> 
> So for this patch:
> 
> Tested-by: Jeremy Linton <jeremy.linton@arm.com>
> Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>