public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, joeyvagedes@microsoft.com,
	Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"rebecca@os.amperecomputing.com" <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
Date: Sat, 28 Oct 2023 16:20:04 +0200	[thread overview]
Message-ID: <c3763bee-716f-fe81-678e-ca73a17ecc6f@redhat.com> (raw)
In-Reply-To: <DM4PR21MB375561074656C6B6BEDC73E8BFDCA@DM4PR21MB3755.namprd21.prod.outlook.com>

On 10/27/23 19:41, Joey Vagedes via groups.io wrote:
> Thank you for the reviews. Pending any reviews other maintainers of these packages would like to do, this patch series is ready to merge. I've updated the PR with the reviewed-by tags:
> 
> https://github.com/tianocore/edk2/pull/4966

I figured I could try just adding the push label to your PR, but the
master branch had advanced meanwhile... So I've now picked up your
patches from the list, added the R-b tags, compared the new branch
against yours from the PR, and then created a new PR, with the "push"
label set:

https://github.com/tianocore/edk2/pull/4972

Hopefully this will complete.

Laszlo

> 
> Joey
> 
> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com> 
> Sent: Friday, October 27, 2023 10:32 AM
> To: devel@edk2.groups.io; Joey Vagedes <joeyvagedes@microsoft.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
> 
> Series:
> 
> Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> On 10/27/2023 11:15 AM, Joey Vagedes via groups.io wrote:
>> Upgrades edk2-pytool-library to v0.19.3 and edk2-pytool-extensions to 
>> v0.25.1 and performs all necessary integrations as noted in the 
>> individual package commits.
>>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>
>> Joey Vagedes (2):
>>    .pytool: Integration of edk2-pytools
>>    BaseTools: Plugin: Integration of edk2-pytools
>>
>>   .pytool/Plugin/HostUnitTestDscCompleteCheck/HostUnitTestDscCompleteCheck.py |  7 ++++---
>>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py                           | 12 ++++++------
>>   BaseTools/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuildPlugin.py  | 10 +++++-----
>>   pip-requirements.txt                                                        |  4 ++--
>>   4 files changed, 17 insertions(+), 16 deletions(-)
>>
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110247): https://edk2.groups.io/g/devel/message/110247
Mute This Topic: https://groups.io/mt/102223493/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-10-28 14:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27 15:15 [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest Joey Vagedes via groups.io
2023-10-27 15:15 ` [edk2-devel] [PATCH v1 1/2] .pytool: Integration of edk2-pytools Joey Vagedes via groups.io
2023-10-27 15:15 ` [edk2-devel] [PATCH v1 2/2] BaseTools: Plugin: " Joey Vagedes via groups.io
2023-10-27 15:45 ` [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest Rebecca Cran via groups.io
2023-10-27 17:32 ` Michael Kubacki
2023-10-27 17:41   ` Joey Vagedes via groups.io
2023-10-28 14:20     ` Laszlo Ersek [this message]
2023-10-28 15:24       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3763bee-716f-fe81-678e-ca73a17ecc6f@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox