From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.6255.1609857900130162466 for ; Tue, 05 Jan 2021 06:45:00 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.20, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: VEEBy0fl/piiW5g04ovGTTU/SeMzMcLtb0gnbWWgp+lTGrY/Spjeun6nZsrqfVYARuL9fDGt+f A4X+SeuBKExQ== X-IronPort-AV: E=McAfee;i="6000,8403,9854"; a="164187349" X-IronPort-AV: E=Sophos;i="5.78,477,1599548400"; d="scan'208";a="164187349" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 06:44:53 -0800 IronPort-SDR: Cgpw66K5bUEHjNu13e8x/IKZLYfhKRpJ8NCJ5Il5Ua76OLNZvYzLxHPZNEAQaFVxiYUsYctIZ1 lJW/f+FIj+WA== X-IronPort-AV: E=Sophos;i="5.78,477,1599548400"; d="scan'208";a="378890742" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.252.38.78]) ([10.252.38.78]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 06:44:42 -0800 Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1] NetworkPkg/DnsDxe: cosmetic fixups From: "Maciej Rabeda" To: Wenyi Xie , devel@edk2.groups.io, jiaxin.wu@intel.com, siyuan.fu@intel.com Cc: songdongkuang@huawei.com Reply-To: devel@edk2.groups.io, maciej.rabeda@linux.intel.com References: <1607065503-29304-1-git-send-email-xiewenyi2@huawei.com> <1607065503-29304-2-git-send-email-xiewenyi2@huawei.com> <16575BAFF098A13A.29174@groups.io> Message-ID: Date: Tue, 5 Jan 2021 15:44:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <16575BAFF098A13A.29174@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: pl Patch merged. Commit: https://github.com/tianocore/edk2/commit/4ad1bd63b28ca103eba21e383c4375a3a91080cf PR: https://github.com/tianocore/edk2/pull/1293 On 05-Jan-21 15:16, Maciej Rabeda wrote: > Thanks for the patch! > > Reviewed-by: Maciej Rabeda > > On 04-Dec-20 08:05, Wenyi Xie wrote: >> add whitespace according to coding style. >> >> Cc: Maciej Rabeda >> Cc: Jiaxin Wu >> Cc: Siyuan Fu >> Signed-off-by: Wenyi Xie >> --- >>   NetworkPkg/DnsDxe/DnsImpl.h     | 2 +- >>   NetworkPkg/DnsDxe/DnsDhcp.c     | 4 ++-- >>   NetworkPkg/DnsDxe/DnsDriver.c   | 4 ++-- >>   NetworkPkg/DnsDxe/DnsImpl.c     | 8 ++++---- >>   NetworkPkg/DnsDxe/DnsProtocol.c | 4 ++-- >>   5 files changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/NetworkPkg/DnsDxe/DnsImpl.h b/NetworkPkg/DnsDxe/DnsImpl.h >> index 10bc399e9ed5..affbb4be8ded 100644 >> --- a/NetworkPkg/DnsDxe/DnsImpl.h >> +++ b/NetworkPkg/DnsDxe/DnsImpl.h >> @@ -125,7 +125,7 @@ typedef struct { >>     EFI_DNS6_COMPLETION_TOKEN  *Token; >>   } DNS6_TOKEN_ENTRY; >>   -union _DNS_FLAGS{ >> +union _DNS_FLAGS { >>     struct { >>       UINT16     RCode:4; >>       UINT16     Zero:3; >> diff --git a/NetworkPkg/DnsDxe/DnsDhcp.c b/NetworkPkg/DnsDxe/DnsDhcp.c >> index 9ea9d7c8f674..8f8b2aab1e32 100644 >> --- a/NetworkPkg/DnsDxe/DnsDhcp.c >> +++ b/NetworkPkg/DnsDxe/DnsDhcp.c >> @@ -131,7 +131,7 @@ ParseDhcp4Ack ( >>           return EFI_OUT_OF_RESOURCES; >>         } >>   -      for(Count=0; Count < ServerCount; Count++){ >> +      for (Count=0; Count < ServerCount; Count++) { >>           CopyMem (ServerList + Count, &OptionList[Index]->Data[4 * >> Count], sizeof (EFI_IPv4_ADDRESS)); >>         } >>   @@ -225,7 +225,7 @@ ParseDhcp6Ack ( >>           return EFI_OUT_OF_RESOURCES; >>         } >>   -      for(Count=0; Count < ServerCount; Count++){ >> +      for (Count=0; Count < ServerCount; Count++) { >>           CopyMem (ServerList + Count, &OptionList[Index]->Data[16 * >> Count], sizeof (EFI_IPv6_ADDRESS)); >>         } >>   diff --git a/NetworkPkg/DnsDxe/DnsDriver.c >> b/NetworkPkg/DnsDxe/DnsDriver.c >> index f099da8a5a95..4db0c6bdd1eb 100644 >> --- a/NetworkPkg/DnsDxe/DnsDriver.c >> +++ b/NetworkPkg/DnsDxe/DnsDriver.c >> @@ -197,11 +197,11 @@ DnsDestroyService ( >>   { >>     UdpIoFreeIo (DnsSb->ConnectUdp); >>   -  if (DnsSb->TimerToGetMap != NULL){ >> +  if (DnsSb->TimerToGetMap != NULL) { >>       gBS->CloseEvent (DnsSb->TimerToGetMap); >>     } >>   -  if (DnsSb->Timer != NULL){ >> +  if (DnsSb->Timer != NULL) { >>       gBS->CloseEvent (DnsSb->Timer); >>     } >>   diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c >> index 25628a5704f0..2edcb280ac4d 100644 >> --- a/NetworkPkg/DnsDxe/DnsImpl.c >> +++ b/NetworkPkg/DnsDxe/DnsImpl.c >> @@ -799,7 +799,7 @@ UpdateDns4Cache ( >>           Item->DnsCache.Timeout = DnsCacheEntry.Timeout; >>             return EFI_SUCCESS; >> -      }else { >> +      } else { >>           return EFI_ACCESS_DENIED; >>         } >>       } >> @@ -897,7 +897,7 @@ UpdateDns6Cache ( >>           Item->DnsCache.Timeout = DnsCacheEntry.Timeout; >>             return EFI_SUCCESS; >> -      }else { >> +      } else { >>           return EFI_ACCESS_DENIED; >>         } >>       } >> @@ -1080,7 +1080,7 @@ IsValidDnsResponse ( >>     NET_LIST_FOR_EACH (Entry, &TokensMap->Used) { >>       *Item = NET_LIST_USER_STRUCT (Entry, NET_MAP_ITEM, Link); >>       Packet = (NET_BUF *) ((*Item)->Value); >> -    if (Packet == NULL){ >> +    if (Packet == NULL) { >>           continue; >>       } else { >> @@ -2127,7 +2127,7 @@ DnsOnTimerRetransmit ( >>           } >>         } >>       } >> -  }else { >> +  } else { >>       // >>       // Iterate through all the children of the DNS service >> instance. Time >>       // out the packet. If maximum retries reached, clean the Token up. >> diff --git a/NetworkPkg/DnsDxe/DnsProtocol.c >> b/NetworkPkg/DnsDxe/DnsProtocol.c >> index 4acc5fca46cf..a0bb58ef1db3 100644 >> --- a/NetworkPkg/DnsDxe/DnsProtocol.c >> +++ b/NetworkPkg/DnsDxe/DnsProtocol.c >> @@ -217,7 +217,7 @@ Dns4Configure ( >>         Dns4InstanceCancelToken(Instance, NULL); >>       } >>   -    if (Instance->UdpIo != NULL){ >> +    if (Instance->UdpIo != NULL) { >>         UdpIoCleanIo (Instance->UdpIo); >>       } >>   @@ -1061,7 +1061,7 @@ Dns6Configure ( >>         Dns6InstanceCancelToken(Instance, NULL); >>       } >>   -    if (Instance->UdpIo != NULL){ >> +    if (Instance->UdpIo != NULL) { >>         UdpIoCleanIo (Instance->UdpIo); >>       } > > > > > >