Re: [PATCH v9 21/46] OvmfPkg/VmgExitLib: Add support for INVD NAE events

["Laszlo Ersek" <lersek@redhat.com>]

On 06/05/20 15:27, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> 
> Under SEV-ES, a INVD intercept generates a #VC exception. VMGEXIT must be
> used to allow the hypervisor to handle this intercept.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 29 ++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> index 0dbb10eee85c..9419651fea2e 100644
> --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> @@ -1164,6 +1164,31 @@ IoioExit (
>    return 0;
>  }
>  
> +/**
> +  Handle a INVD event.
> +
> +  Use the VMGEXIT instruction to handle a INVD event.
> +
> +  @param[in, out] Ghcb             Pointer to the Guest-Hypervisor Communication
> +                                   Block
> +  @param[in, out] Regs             x64 processor context
> +  @param[in]      InstructionData  Instruction parsing context
> +
> +  @return 0                        Event handled successfully
> +  @return Others                   New exception value to propagate
> +
> +**/
> +STATIC
> +UINT64
> +InvdExit (
> +  IN OUT GHCB                     *Ghcb,
> +  IN OUT EFI_SYSTEM_CONTEXT_X64   *Regs,
> +  IN     SEV_ES_INSTRUCTION_DATA  *InstructionData
> +  )
> +{
> +  return VmgExit (Ghcb, SVM_EXIT_INVD, 0, 0);
> +}
> +
>  /**
>    Handle a CPUID event.
>  
> @@ -1356,6 +1381,10 @@ VmgExitHandleVc (
>      NaeExit = CpuidExit;
>      break;
>  
> +  case SVM_EXIT_INVD:
> +    NaeExit = InvdExit;
> +    break;
> +
>    case SVM_EXIT_IOIO_PROT:
>      NaeExit = IoioExit;
>      break;
> 

looks good, thanks