public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Abdul Lateef Attar <abdattar@amd.com>,
	Abner Chang <abner.chang@amd.com>,
	"Warkentin, Andrei" <andrei.warkentin@intel.com>,
	Andrew Fish <afish@apple.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"S, Ashraf Ali" <ashraf.ali.s@intel.com>,
	Bibo Mao <maobibo@loongson.cn>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	"West, Catharine" <catharine.west@intel.com>,
	Chao Li <lichao@loongson.cn>,
	"Chiu, Chasel" <chasel.chiu@intel.com>,
	"Duggapu, Chinni B" <chinni.b.duggapu@intel.com>,
	Duke Zhai <duke.zhai@amd.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	Eric Xing <eric.xing@amd.com>, Gerd Hoffmann <kraxel@redhat.com>,
	"Guo, Gua" <gua.guo@intel.com>, "Dong, Guo" <guo.dong@intel.com>,
	Igniculus Fu <igniculus.fu@amd.com>,
	"Lu, James" <james.lu@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Kelly Steele <kelly.steele@intel.com>, Ken Yao <ken.yao@amd.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Michael Roth <michael.roth@amd.com>,
	"Xu, Min M" <min.m.xu@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	Paul Grimes <paul.grimes@amd.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>, Rebecca Cran <rebecca@bsdio.com>,
	"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	"Rhodes, Sean" <sean@starlabs.systems>,
	"Zeng, Star" <star.zeng@intel.com>,
	Sunil V L <sunilvl@ventanamicro.com>,
	"Mohapatra, Susovan" <susovan.mohapatra@intel.com>,
	"Kuo, Ted" <ted.kuo@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	USER0FISH <libing1202@outlook.com>,
	Xianglai li <lixianglai@loongson.cn>,
	"Chen, Christine" <yuwei.chen@intel.com>,
	caiyuqing379 <caiyuqing_hz@outlook.com>,
	dahogn <dahogn@hotmail.com>, meng-cz <mengcz1126@gmail.com>
Subject: Re: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules
Date: Sat, 24 Feb 2024 19:37:32 +0100	[thread overview]
Message-ID: <c39b376f-198e-ee6e-675b-0e3c3513d049@redhat.com> (raw)
In-Reply-To: <CO1PR11MB49292DF95DFD9592771B75FAD24D2@CO1PR11MB4929.namprd11.prod.outlook.com>

On 2/15/24 18:29, Michael D Kinney wrote:

> The current INF Spec uses INF_VERSION of 1.27.

Side topic:

the build spec says in 8.7:

  https://tianocore-docs.github.io/edk2-BuildSpecification/draft/8_pre-build_autogen_stage/87_generated_asbuilt_inf_files.html

that the build tool will *downgrade* the INF_VERSION value from the
source module INF to the most recent version that the build tools know
about, in the AsBuilt INF files.

This is generally confusing and potentially wrong (regardless of what
I'm trying to do here). The latest released version of the INF spec is
1.27 (as you say), but in edk2 (as of commit edc6681206c1), the file
"BaseTools/Source/Python/AutoGen/ModuleAutoGen.py" contains:

gInfSpecVersion = "0x00010017"

which, IIUC, means that the tools will downgrade the AsBuilt INF files
that originally (in source form) comply with version 1.27, to 1.23.

How is that not a bug?

... Well, in fact I wanted to check this in action, and so I picked
"OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf". The source INF file has
INF_VERSION=1.29. The AsBuilt INF file however contains
INF_VERSION=0x00010035, which corresponds to "1.53" (1.29 would be
0x0001001D). Now I'm even more confused: 0x00010035 is *neither* the
original value *nor* the downgraded value that I'd expect from
"gInfSpecVersion". What's happening here? What are the AsBuilt INF files
used for?

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115908): https://edk2.groups.io/g/devel/message/115908
Mute This Topic: https://groups.io/mt/104210524/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2024-02-24 18:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07  0:50 [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules Laszlo Ersek
2024-02-07  1:04 ` [edk2-devel] [PATCH 00/11] " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 01/11] OvmfPkg/Sec: Use correct prototype of ProcessLibraryConstructorList() Laszlo Ersek
2024-02-14 14:27     ` Ard Biesheuvel
2024-02-07  1:04   ` [edk2-devel] [PATCH 02/11] OvmfPkg/RiscVVirt/Sec: don't #include <Library/PeimEntryPoint.h> Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 03/11] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 04/11] ArmPlatformPkg: remove SEC ProcessLibraryConstructorList() declarations Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 05/11] ArmVirtPkg: remove SEC ProcessLibraryConstructorList() declaration Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 06/11] EmulatorPkg: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 07/11] IntelFsp2Pkg: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 08/11] OvmfPkg/RiscVVirt: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 09/11] OvmfPkg: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 10/11] UefiCpuPkg: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 11/11] UefiPayloadPkg: " Laszlo Ersek
2024-02-07  1:09 ` [edk2-devel] [edk2-platforms PATCH 0/6] clean up SEC ProcessLibraryConstructorList() declarations Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 1/6] ChachaniBoardPkg: remove SEC ProcessLibraryConstructorList() declaration Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 2/6] BeagleBoardPkg: " Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 3/6] QuarkPlatformPkg: " Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 4/6] SimicsOpenBoardPkg: fix SEC ProcessLibraryConstructorList() prototype Laszlo Ersek
2024-02-09  0:07     ` Nate DeSimone
2024-02-09  9:24       ` Laszlo Ersek
2024-02-09 22:53         ` Nate DeSimone
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 5/6] LoongArchQemuPkg: " Laszlo Ersek
2024-02-19  2:21     ` Chao Li
2024-02-19 20:08       ` Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 6/6] SG2042Pkg: clean up SEC ProcessLibraryConstructorList() declaration Laszlo Ersek
2024-02-14 14:25   ` [edk2-devel] [edk2-platforms PATCH 0/6] clean up SEC ProcessLibraryConstructorList() declarations Ard Biesheuvel
2024-02-07  1:16 ` [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules Michael D Kinney
2024-02-07 15:40   ` Laszlo Ersek
2024-02-08 16:40     ` Michael D Kinney
2024-02-15  7:57       ` Laszlo Ersek
2024-02-15 17:29         ` Michael D Kinney
2024-02-16 14:16           ` Laszlo Ersek
2024-02-16 17:21             ` Michael D Kinney
2024-02-24 18:02           ` Laszlo Ersek
2024-02-24 18:37           ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c39b376f-198e-ee6e-675b-0e3c3513d049@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox