public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Gerd Hoffmann <kraxel@redhat.com>, "nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH v2 08/11] ArmVirtPkg: Add new ignored spelling errors
Date: Tue, 13 Dec 2022 10:38:11 +0000	[thread overview]
Message-ID: <c3b29835-7960-d5db-f60a-834a04ac0c15@arm.com> (raw)
In-Reply-To: <20220518001338.1380-9-mikuback@linux.microsoft.com>

Hi Michael,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 18/05/2022 01:13 am, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> The SpellCheck plugin began reporting new typos that were previously
> missed. This change adds the new words reported to the extended
> words list in ArmVirtPkg.ci.yaml.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 25 ++++++++++++--------
>   1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index d5d63ddd4fd7..e6963a719ea1 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -101,27 +101,32 @@
>           "ExtendWords": [
>               "acpiview",
>               "armltd",
> -            "ssdts",
> -            "setjump",
> -            "plong",
> -            "lparam",
> -            "lpdword",
> -            "lpthread",
> -            "lresult",
>               "bootable",
>               "bsymbolic",
> +            "cloudhv",
> +            "devicepath",
>               "endiannness",
> +            "finalise",
>               "fvmain",
> +            "kvmtool",
> +            "lparam",
> +            "lpdword",
> +            "lpthread",
> +            "lresult",
>               "multiboot",
> +            "periph",
> +            "plong",
> +            "prefetchable",
>               "qemu's",
>               "ramdisk",
>               "ramfb",
> +            "redist",
> +            "setjump",
> +            "ssdts",
>               "unbootable",
>               "virt's",
>               "werror",
> -            "xenio",
> -            "kvmtool",
> -            "cloudhv"
> +            "xenio"
>           ],           # words to extend to the dictionary for this package
>           "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
>           "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)

  reply	other threads:[~2022-12-13 10:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  0:13 [PATCH v2 00/11] Fix new typos reported Michael Kubacki
2022-05-18  0:13 ` [PATCH v2 01/11] PrmPkg: " Michael Kubacki
2022-05-18  0:13 ` [PATCH v2 02/11] StandaloneMmPkg: " Michael Kubacki
2022-12-13 10:26   ` Sami Mujawar
2022-12-14  3:03     ` [edk2-devel] " Michael Kubacki
2022-05-18  0:13 ` [PATCH v2 03/11] DynamicTablesPkg: " Michael Kubacki
2022-05-18  0:13 ` [PATCH v2 04/11] UnitTestFrameworkPkg: " Michael Kubacki
2022-05-18  0:13 ` [PATCH v2 05/11] FatPkg: " Michael Kubacki
2022-05-18  0:13 ` [PATCH v2 06/11] FmpDevicePkg: " Michael Kubacki
2022-05-18  0:13 ` [PATCH v2 07/11] ArmPkg: Ignore " Michael Kubacki
2022-12-13 10:36   ` Sami Mujawar
2022-05-18  0:13 ` [PATCH v2 08/11] ArmVirtPkg: Add new ignored spelling errors Michael Kubacki
2022-12-13 10:38   ` Sami Mujawar [this message]
2022-05-18  0:13 ` [PATCH v2 09/11] .azurepipelines: Fix cspell version to v5.20.0 Michael Kubacki
2022-05-18  0:13 ` [PATCH v2 10/11] .pytool/plugin/SpellCheck: Allow compound words Michael Kubacki
2022-05-18  0:13 ` [PATCH v2 11/11] .pytool/plugin/SpellCheck: Add more common words Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3b29835-7960-d5db-f60a-834a04ac0c15@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox