From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A665E74004E for ; Mon, 22 Apr 2024 09:21:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=H9YeoAtnjfWCI7csxTRdgFA3xraZg9SrqGvlplxyfT8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1713777703; v=1; b=OqR5gD70J8OfEG0HNK4ZbNcgnSfplwiZIKTZ/f5CxUqj+lzb7Izhd5Mb9iyPUww15hUFIamY o9iDYa+iwFrSCQJ+I3nejH97U0XyOAK7gvxRAetzTF3qQpVcaskD8Wra6EaThaJdoHuaj1j+bZr xiO7ytBng7Jx3SF6UVSrbqUN2VvvquwBxna/Ar+0E7gImw3g/xOZeaMiEosbtM0akGqhg4N8urp oVMrHAgM+N6HsmIJuFujncGekfNw3Imzyi0ut6cabYSseiu1IWBESEa8146hkp2mfNoBFnGkpEf 2unZvqC7GW8LNLpyzMXeTJUkRgpxUugITCK9y8uol0f8w== X-Received: by 127.0.0.2 with SMTP id TBejYY7687511xIudlM0eYuh; Mon, 22 Apr 2024 02:21:43 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.14143.1713777701173610026 for ; Mon, 22 Apr 2024 02:21:41 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8BxnusgLCZm4rcAAA--.2925S3; Mon, 22 Apr 2024 17:21:36 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxXN4cLCZm6C0BAA--.5300S3; Mon, 22 Apr 2024 17:21:32 +0800 (CST) Message-ID: Date: Mon, 22 Apr 2024 17:21:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 0/4] Adjust the QemuFwCfgLibMmio and add PEI stage From: "Chao Li" To: devel@edk2.groups.io, kraxel@redhat.com, Ard Biesheuvel Cc: Jiewen Yao , Leif Lindholm , Sami Mujawar , Sunil V L , Andrei Warkentin Reply-To: devel@edk2.groups.io,lichao@loongson.cn References: <20240417081256.3125187-1-lichao@loongson.cn> <17C70907D38C479B.20815@groups.io> In-Reply-To: <17C70907D38C479B.20815@groups.io> X-CM-TRANSID: AQAAf8DxXN4cLCZm6C0BAA--.5300S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAPCGYl0BIFOQAAs7 X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 22 Apr 2024 02:21:41 -0700 Resent-From: lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QfXHLEN7aJv6MNEJdOFQft2fx7686176AA= Content-Type: multipart/alternative; boundary="------------0ZssIQi4fKyZdIYg107xHBoy" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=OqR5gD70; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --------------0ZssIQi4fKyZdIYg107xHBoy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ard, Could you take a look at this patch set and give you some suggestions? Thanks, Chao On 2024/4/17 18:01, Chao Li wrote: > > Hi Gerd, > > On 2024/4/17 17:35, Gerd Hoffmann wrote: >> On Wed, Apr 17, 2024 at 04:12:56PM +0800, Chao Li wrote: >>> Patch1: Added three PCDs for QemuFwCfgLibMmio >>> Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE >>> stage library. >>> Patch3: Added QemuFwCfgMmiLib PEI version >>> Patch4: Rename QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf and >>> enable it in AARCH64 and RISCV64. >> Ok, I see, you are using the PCDs because global variables don't work >> in PEI. > Yes. :) >> Alternative approach would be to create a HOB for that (see >> EFI_HOB_PLATFORM_INFO used by X64). Not sure this is a good idea >> though given that we have three different architectures using that code. >> Ard, any advise? > I think HOB might be heavy, and the dynamically PCD is also uses the=20 > HOB, so this I think this way is more simpler. I'm also looking=20 > forward Ard's suggestions. :) >>> OvmfPkg: Add three PCDs for QemuFwCfgLib >>> OvmfPkg: Separate QemuFwCfgLibMmio.c into two files >> This patch should be splitted into two, one doing the code split without >> functional change, and one which switches from global variables to PCDs >> (or HOB). > OK, I will split it in V2. >> Otherwise this looks good to me (and I'd suggest to keep and merge this >> as separate patch series). > Sure! >> take care, >> Gerd >> >> >> >> >> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118079): https://edk2.groups.io/g/devel/message/118079 Mute This Topic: https://groups.io/mt/105573103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------0ZssIQi4fKyZdIYg107xHBoy Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Ard,

Could you take a look at this patch set and give you some suggestions?


=
Thanks,
Chao
On 2024/4/17 18:01, Chao Li wrote:

Hi Gerd,

On 2024/4/17 17:35, Gerd Hoffmann wrote:
On Wed, Apr 17, 2024 at 04:1=
2:56PM +0800, Chao Li wrote:

Patch1: Added three PCDs f=
or QemuFwCfgLibMmio
Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE
stage library.
Patch3: Added QemuFwCfgMmiLib PEI version
Patch4: Rename QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf and
enable it in AARCH64 and RISCV64.

Ok, I see, you are using the=
 PCDs because global variables don't work
in PEI.
Yes. :)
Alternative approach would b=
e to create a HOB for that (see
EFI_HOB_PLATFORM_INFO used by X64).  Not sure this is a good idea
though given that we have three different architectures using that code.
Ard, any advise?
I think HOB might be heavy, and the dynamically PCD is also uses the HOB, so this I think this way is more simpler. I'm also looking forward Ard's suggestions. :)
  OvmfPkg: Add three PCDs =
for QemuFwCfgLib
  OvmfPkg: Separate QemuFwCfgLibMmio.c into two files

This patch should be splitte=
d into two, one doing the code split without
functional change, and one which switches from global variables to PCDs
(or HOB).
OK, I will split it in V2.
Otherwise this looks good to=
 me (and I'd suggest to keep and merge this
as separate patch series).
Sure!
take care,
  Gerd
=20
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118079) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------0ZssIQi4fKyZdIYg107xHBoy--