From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.64220.1673548463074922947 for ; Thu, 12 Jan 2023 10:34:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Cu63g18u; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673548462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AD9r1kYcm5LqOy1wKHMZ+1rweCQILLPuXefPSbE+6sA=; b=Cu63g18uvCBa/8ZVDABgiqPPDS6y5EClXjbO03umzsQSkdViA0wCNdTTtheV33VoALA6Sf ZoZGoSs977zLsW1WXDaURx2AQuHoiXTcpzUx0fdUdpgv67jz6aaSkw1wHXH9yxmHjf/uk9 8gU3tI2BQuF6mfGb5WVrafCbhW5+ddE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-326-eCkQSPZpOnaAgAMDQCA71A-1; Thu, 12 Jan 2023 13:34:19 -0500 X-MC-Unique: eCkQSPZpOnaAgAMDQCA71A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A18BC3C0253E; Thu, 12 Jan 2023 18:34:18 +0000 (UTC) Received: from [10.39.192.93] (unknown [10.39.192.93]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D938492B00; Thu, 12 Jan 2023 18:34:17 +0000 (UTC) Message-ID: Date: Thu, 12 Jan 2023 19:34:16 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 0/8] OvmfPkg: check 64bit mmio window for resource conflicts To: devel@edk2.groups.io, kraxel@redhat.com Cc: Oliver Steffen , Ard Biesheuvel , Jordan Justen , Pawel Polawski , Jiewen Yao References: <20230112093425.1228300-1-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20230112093425.1228300-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 1/12/23 10:34, Gerd Hoffmann wrote: > v3: > - Add / fix comments, add notes to commit messages. > - Make functions static. > - Logging tweaks. > - Fix windows compiler warnings. > - Add patches (5,6,7) moving MMCONFIG to 0xe0000000, simplifying code > and reducing differences between 'pc' and 'q35' along the way. > Eventually we want split them into a separate series, but some of > this was discussed in v2 review, so I just appended them here for > now. > v2: > - split up PlatformScanOrAdd64BitE820Ram() into scan function with > callbacks, store results in PlatformInfoHob struct. > > Gerd Hoffmann (8): > OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB > OvmfPkg/PlatformInitLib: Add PlatformGetLowMemoryCB > OvmfPkg/PlatformInitLib: Add PlatformAddHobCB > OvmfPkg/PlatformInitLib: Add PlatformReservationConflictCB > OvmfPkg/PlatformInitLib: reorder PlatformQemuUc32BaseInitialization > OvmfPkg/PlatformInitLib: update address space layout comment > OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000 > OvmfPkg/PlatformInitLib: simplify mtrr setup > > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > OvmfPkg/OvmfXen.dsc | 2 +- > OvmfPkg/Include/Library/PlatformInitLib.h | 3 +- > OvmfPkg/Library/PeilessStartupLib/Hob.c | 3 +- > .../PeilessStartupLib/PeilessStartup.c | 7 +- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 384 ++++++++++-------- > OvmfPkg/Library/PlatformInitLib/Platform.c | 39 +- > OvmfPkg/PlatformPei/MemDetect.c | 3 +- > 12 files changed, 246 insertions(+), 205 deletions(-) > please proceed with this without me. Since I've been back to edk2, just "temporarily" (until the BZs I've reported in 2023 would be fixed), my stress levels have been through the roof, I'm again working 10-12 hour days, things are falling apart around me. I'm simply unable to ignore things on the list that I have some knowledge for commenting upon, and that traffic happens to be sizeable, and my comments happen to be detailed, and while that may be good for edk2, it's *destroying* me. I'm an edk2 addict / workaholic that has relapsed. I'm out. Thanks for the collaboration. I must save myself. Laszlo