From: "PierreGondois" <pierre.gondois@arm.com>
To: Ard Biesheuvel <ardb@kernel.org>, devel@edk2.groups.io
Cc: leif@nuviainc.com
Subject: Re: [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout
Date: Wed, 2 Feb 2022 10:42:44 +0100 [thread overview]
Message-ID: <c410de52-ae14-723a-6108-a7bb46f88bc3@arm.com> (raw)
In-Reply-To: <20220201180302.743162-1-ardb@kernel.org>
Hi,
The value also gets updated from 3 to 5, is it possible to note it in the
commit message or to let it to 3 ?
Otherwise the patch looks good to me,
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
On 2/1/22 7:03 PM, Ard Biesheuvel wrote:
> Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up
> to the Timeout EFI variable automatically, which is how the boot manager
> stores the timeout preference.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> ArmVirtPkg/ArmVirtKvmTool.dsc | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc
> index a1bf4b9be87b..3bd3ebd6e0b3 100644
> --- a/ArmVirtPkg/ArmVirtKvmTool.dsc
> +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc
> @@ -170,9 +170,10 @@ [PcdsPatchableInModule.common]
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x0
>
> +[PcdsDynamicHii]
> + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalVariableGuid|0x0|5
> +
> [PcdsDynamicDefault.common]
> - gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
> -
> gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0
> gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0
> gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0
>
next prev parent reply other threads:[~2022-02-02 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 18:03 [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout Ard Biesheuvel
2022-02-02 9:42 ` PierreGondois [this message]
2022-02-02 10:03 ` [edk2-devel] " Sami Mujawar
2022-02-25 16:48 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c410de52-ae14-723a-6108-a7bb46f88bc3@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox