From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.61716.1643794944466833096 for ; Wed, 02 Feb 2022 01:42:24 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D8F71FB; Wed, 2 Feb 2022 01:42:23 -0800 (PST) Received: from [10.34.129.17] (e126645.nice.arm.com [10.34.129.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 43B8E3F40C; Wed, 2 Feb 2022 01:42:22 -0800 (PST) Subject: Re: [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout To: Ard Biesheuvel , devel@edk2.groups.io Cc: leif@nuviainc.com References: <20220201180302.743162-1-ardb@kernel.org> From: "PierreGondois" Message-ID: Date: Wed, 2 Feb 2022 10:42:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220201180302.743162-1-ardb@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, The value also gets updated from 3 to 5, is it possible to note it in the commit message or to let it to 3 ? Otherwise the patch looks good to me, Reviewed-by: Pierre Gondois On 2/1/22 7:03 PM, Ard Biesheuvel wrote: > Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up > to the Timeout EFI variable automatically, which is how the boot manager > stores the timeout preference. > > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtKvmTool.dsc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc > index a1bf4b9be87b..3bd3ebd6e0b3 100644 > --- a/ArmVirtPkg/ArmVirtKvmTool.dsc > +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc > @@ -170,9 +170,10 @@ [PcdsPatchableInModule.common] > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x0 > > +[PcdsDynamicHii] > + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalVariableGuid|0x0|5 > + > [PcdsDynamicDefault.common] > - gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 > - > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0 > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0 > gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0 >