From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 199C5D80127 for ; Tue, 15 Aug 2023 01:22:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pwKxtY90T4acMNIhkCPoiTTayj318IKSmpUwrXEpgSk=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692062536; v=1; b=UET8xSuymEglr+fSUSYlyaosozkWHEpJn0kgLa737lTya3A/UU1gVzj6/jF42gnE5SJIFBPh s3Rfe8afl4B9SgofaaK6Lf7vMONzSockZ5QrEVjjfdk6sFOWrhwq6OoxI76vOe/k7VxVDLKfz+/ ISf5tGybq+WHrhVAgubJCvfc= X-Received: by 127.0.0.2 with SMTP id 8EynYY7687511xOuiEFXQ4b8; Mon, 14 Aug 2023 18:22:16 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.124514.1692062536328402728 for ; Mon, 14 Aug 2023 18:22:16 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id A16302109443; Mon, 14 Aug 2023 18:22:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A16302109443 Message-ID: Date: Mon, 14 Aug 2023 21:22:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/7] .pytool: Set uncrustify check to audit only From: "Michael Kubacki" To: devel@edk2.groups.io, vnowkakeane@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com References: <20230809213226.1387-1-vnowkakeane@linux.microsoft.com> <20230809213226.1387-2-vnowkakeane@linux.microsoft.com> <177B69072E52D32F.12117@groups.io> In-Reply-To: <177B69072E52D32F.12117@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bVTgCjoPmrA3A2vZ9EjpI4QEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UET8xSuy; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none) Looking at the whole series, I see you did this to prevent intermediate=20 CI failures while adjusting the code to comply with the future settings=20 change. If it stays this way, the commit message should clearly call this out.=20 For example: "Temporarily set uncrustify to audit only mode so the following commits=20 can adjust the code for new formatting settings before those settings=20 are applied." The scope could also be adjusted in uncrustify_plug_in.yaml to something=20 other than "cibuild" that does not match known scopes (like "inactive")=20 but I think this is fine if the message is clear about why the value is=20 being temporarily modified. Thanks, Michael On 8/14/2023 9:06 PM, Michael Kubacki wrote: > Was this meant to be included in the series? We wouldn't want audit only= =20 > mode always enabled. >=20 > On 8/9/2023 5:32 PM, VivianNK wrote: >> Temporarily set uncrustify to audit only to prevent build failures. >> >> CC: Sean Brogan >> CC: Michael Kubacki >> CC: Michael D Kinney >> CC: Liming Gao >> Signed-off-by: Vivian Nowka-Keane >> --- >> =C2=A0 .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +- >> =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py=20 >> b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py >> index 8dc9ffe6945a..8978ffc443bf 100644 >> --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py >> +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py >> @@ -530,7 +530,7 @@ class UncrustifyCheck(ICiBuildPlugin): >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Initializes optio= ns that influence test case output. >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ >> >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self._audit_only_mode =3D Fa= lse >> >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self._audit_only_mode =3D Tr= ue >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self._output_file= _diffs =3D True >> >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if "AuditOnly" in= self._package_config and=20 >> self._package_config["AuditOnly"]: >> >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107753): https://edk2.groups.io/g/devel/message/107753 Mute This Topic: https://groups.io/mt/100655290/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-