public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ashish Singhal" <ashishsingha@nvidia.com>
To: <devel@edk2.groups.io>, <ray.ni@intel.com>, <zhichao.gao@intel.com>
Cc: Ashish Singhal <ashishsingha@nvidia.com>
Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser
Date: Sun, 19 Jan 2020 22:44:34 -0700	[thread overview]
Message-ID: <c43c948b564e614b99217d3b14bb6635f81b2766.1579498924.git.ashishsingha@nvidia.com> (raw)

FADT parser was checking for reduced ACPI flag incorrectly
leading to incorrect error message if FIRMWARE_CTRL and
X_FIRMWARE_CTRL are both 0.

Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
---
 .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c
index 5b8cc174f1..8acfbac3b1 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c
@@ -253,7 +253,7 @@ ParseAcpiFadt (
     // present.
     if ((Trace) &&
         (Flags != NULL) &&
-        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != 0)) {
+        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != EFI_ACPI_6_3_HW_REDUCED_ACPI)) {
       IncrementErrorCount ();
       Print (L"ERROR: No FACS table found, "
                L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are zero.\n");
-- 
2.17.1


             reply	other threads:[~2020-01-20  5:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20  5:44 Ashish Singhal [this message]
2020-01-20  7:42 ` [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Gao, Zhichao
2020-01-27 17:28   ` Ashish Singhal
2020-01-31  5:32     ` Gao, Zhichao
2020-02-10 17:39       ` Ashish Singhal
2020-02-11  2:54         ` Gao, Zhichao
2020-02-11  5:22           ` Ashish Singhal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c43c948b564e614b99217d3b14bb6635f81b2766.1579498924.git.ashishsingha@nvidia.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox