From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mx.groups.io with SMTP id smtpd.web12.6950.1579499078729314725 for ; Sun, 19 Jan 2020 21:44:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=JC3vgj2Y; spf=pass (domain: nvidia.com, ip: 216.228.121.64, mailfrom: ashishsingha@nvidia.com) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 19 Jan 2020 21:44:23 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Sun, 19 Jan 2020 21:44:37 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Sun, 19 Jan 2020 21:44:37 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 20 Jan 2020 05:44:37 +0000 Received: from hqnvemgw03.nvidia.com (10.124.88.68) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 20 Jan 2020 05:44:37 +0000 Received: from ashishsingha-lnx.nvidia.com (Not Verified[10.28.48.147]) by hqnvemgw03.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Sun, 19 Jan 2020 21:44:37 -0800 From: "Ashish Singhal" To: , , CC: Ashish Singhal Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Date: Sun, 19 Jan 2020 22:44:34 -0700 Message-ID: X-Mailer: git-send-email 2.17.1 X-NVConfidentiality: public Return-Path: ashishsingha@nvidia.com MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579499063; bh=aKIxGGSgYlkQMDOwR9T0kYThfLXeaxsrDxeu1qXePaI=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=JC3vgj2YlZtMPn+YRwSGK9csx1vOnHGISesDVB1FzI2wCdkw5onurR7XoXpOmUOsZ RRT4FIO54UAjxt5pIU4ytdDr+IF2l0bOQCjM6LXDfqblldjkI7RZ1isvP7QvyrT2/O 3cbKURYQ0XnN2SGlUOhwyToWJPgA7ukP+lqr4X9rwiqEFFjyjzLqmCdBvvFy1sC5I4 yTBMGPDkxNBGL51AMbYKTSIXAqcNqhO0fbFS5Ncfrm95p+/Sd64RXj5G/4DZJr6NV6 WZFXxyaY2t3o7dIkYGhP//1IvVJFmlI5W4amWgP3S3ZMabrXQcEW2TDVeJqMsiWchF iaETL/uE3NOvw== Content-Type: text/plain FADT parser was checking for reduced ACPI flag incorrectly leading to incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are both 0. Signed-off-by: Ashish Singhal --- .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c index 5b8cc174f1..8acfbac3b1 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c @@ -253,7 +253,7 @@ ParseAcpiFadt ( // present. if ((Trace) && (Flags != NULL) && - ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != 0)) { + ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != EFI_ACPI_6_3_HW_REDUCED_ACPI)) { IncrementErrorCount (); Print (L"ERROR: No FACS table found, " L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are zero.\n"); -- 2.17.1