From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Pierre.Gondois@arm.com, leif@nuviainc.com,
thomas.abraham@arm.com, devel@edk2.groups.io
Cc: sami.mujawar@arm.com
Subject: Re: [PATCH v1 00/16] Fix Ecc reported errors in ArmPlatformPkg
Date: Wed, 9 Dec 2020 16:33:05 +0100 [thread overview]
Message-ID: <c4425c4b-6f72-7cd6-7d4a-2d854c3a0711@arm.com> (raw)
In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com>
On 12/3/20 7:19 PM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> The Ecc tools available in the BaseTools package checks for
> good practice coding standards. Some errors reported while
> running Ecc on edk2/ArmPlatformPkg require modifications.
>
> This patch set has a dependency over a similar patch set
> named "Fix Ecc reported errors from ArmPlatformPkg" for
> edk2-platforms and should not be merged independently.
>
> The changes can be seen at: https://github.com/PierreARM/edk2/tree/1537_Ecc_ArmPlatformPkg_v1
>
> Pierre Gondois (16):
> ArmPlatformPkg: Fix Ecc error 3001 in NorFlashDxe
> ArmPlatformPkg: Fix Ecc error 3002 in PL011UartLib
> ArmPlatformPkg: Fix Ecc error 3002 in PL061GpioDxe
> ArmPlatformPkg: Fix Ecc error 5007 in LcdGraphicsOutputDxe
> ArmPlatformPkg: Fix Ecc error 5007 in NorFlashDxe
> ArmPlatformPkg: Fix Ecc error 5007 in PL061GpioDxe
> ArmPlatformPkg: Fix Ecc error 5007 in PL031RealTimeClockLib
> ArmPlatformPkg: Fix Ecc error 10016 in PrePi
> ArmPlatformPkg: Fix Ecc error 10016 in LcdPlatformNullLib
> ArmPlatformPkg: Fix Ecc error 10014 in LcdGraphicsOutputDxe
> ArmPlatformPkg: Fix Ecc error 10014 in PL061GpioDxe
> ArmPlatformPkg: Fix Ecc error 10014 in SP805WatchdogDxe
> ArmPlatformPkg: Fix Ecc error 10006 in ArmPlatformPkg.dsc
> ArmPlatformPkg: Fix Ecc error 8001 in PrePi
> ArmPlatformPkg: Fix Ecc error 8005
> ArmPlatformPkg: Fix cspell reported spelling/wording
>
Patches above
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Merged as #1207 into master.
> ArmPlatformPkg: Fix Ecc error 8005
This one needs further discussion, and alignment with edk2-platforms
changes.
> ArmPlatformPkg/ArmPlatformPkg.dsc | 9 +-
> .../LcdGraphicsOutputBlt.c | 98 ++++++++++---------
> .../LcdGraphicsOutputDxe.c | 30 +++---
> .../LcdGraphicsOutputDxe.h | 4 +-
> .../LcdGraphicsOutputDxe.inf | 5 +-
> .../Drivers/NorFlashDxe/NorFlashDxe.c | 8 +-
> .../Drivers/PL061GpioDxe/PL061Gpio.c | 12 +--
> .../Drivers/PL061GpioDxe/PL061GpioDxe.inf | 3 +-
> .../SP805WatchdogDxe/SP805WatchdogDxe.inf | 3 +-
> .../Include/Library/LcdPlatformLib.h | 21 ++--
> .../LcdPlatformNullLib/LcdPlatformNullLib.c | 4 +-
> .../LcdPlatformNullLib/LcdPlatformNullLib.inf | 3 +-
> .../Library/PL011UartLib/PL011UartLib.c | 12 +--
> .../PL031RealTimeClockLib.c | 4 +-
> ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 4 +-
> .../PrePi/AArch64/ModuleEntryPoint.S | 4 +-
> ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 4 +-
> ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm | 4 +-
> ArmPlatformPkg/PrePi/PeiUniCore.inf | 3 +-
> ArmPlatformPkg/PrePi/PrePi.h | 4 +-
> 20 files changed, 126 insertions(+), 113 deletions(-)
>
> --
> 2.17.1
>
prev parent reply other threads:[~2020-12-09 15:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 18:19 [PATCH v1 00/16] Fix Ecc reported errors in ArmPlatformPkg PierreGondois
2020-12-03 18:19 ` [PATCH v1 01/16] ArmPlatformPkg: Fix Ecc error 3001 in NorFlashDxe PierreGondois
2020-12-03 18:19 ` [PATCH v1 02/16] ArmPlatformPkg: Fix Ecc error 3002 in PL011UartLib PierreGondois
2020-12-03 18:19 ` [PATCH v1 03/16] ArmPlatformPkg: Fix Ecc error 3002 in PL061GpioDxe PierreGondois
2020-12-03 18:19 ` [PATCH v1 04/16] ArmPlatformPkg: Fix Ecc error 5007 in LcdGraphicsOutputDxe PierreGondois
2020-12-03 18:19 ` [PATCH v1 05/16] ArmPlatformPkg: Fix Ecc error 5007 in NorFlashDxe PierreGondois
2020-12-03 18:19 ` [PATCH v1 06/16] ArmPlatformPkg: Fix Ecc error 5007 in PL061GpioDxe PierreGondois
2020-12-03 18:19 ` [PATCH v1 07/16] ArmPlatformPkg: Fix Ecc error 5007 in PL031RealTimeClockLib PierreGondois
2020-12-03 18:19 ` [PATCH v1 08/16] ArmPlatformPkg: Fix Ecc error 10016 in PrePi PierreGondois
2020-12-03 18:19 ` [PATCH v1 09/16] ArmPlatformPkg: Fix Ecc error 10016 in LcdPlatformNullLib PierreGondois
2020-12-03 18:19 ` [PATCH v1 10/16] ArmPlatformPkg: Fix Ecc error 10014 in LcdGraphicsOutputDxe PierreGondois
2020-12-03 18:19 ` [PATCH v1 11/16] ArmPlatformPkg: Fix Ecc error 10014 in PL061GpioDxe PierreGondois
2020-12-03 18:19 ` [PATCH v1 12/16] ArmPlatformPkg: Fix Ecc error 10014 in SP805WatchdogDxe PierreGondois
2020-12-03 18:19 ` [PATCH v1 13/16] ArmPlatformPkg: Fix Ecc error 10006 in ArmPlatformPkg.dsc PierreGondois
2020-12-03 18:19 ` [PATCH v1 14/16] ArmPlatformPkg: Fix Ecc error 8001 in PrePi PierreGondois
2020-12-03 18:19 ` [PATCH v1 15/16] ArmPlatformPkg: Fix Ecc error 8005 PierreGondois
2020-12-09 15:09 ` Ard Biesheuvel
2020-12-03 18:19 ` [PATCH v1 16/16] ArmPlatformPkg: Fix cspell reported spelling/wording PierreGondois
2020-12-09 15:33 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4425c4b-6f72-7cd6-7d4a-2d854c3a0711@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox