public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>, edk2-devel@lists.01.org
Subject: Re: [Patch V3 0/3] StartAllAPs should not use disabled APs
Date: Wed, 25 Jul 2018 14:12:28 +0200	[thread overview]
Message-ID: <c47f474d-8dda-fd06-b7f1-5891b35cf5a1@redhat.com> (raw)
In-Reply-To: <20180725075020.240-1-eric.dong@intel.com>

On 07/25/18 09:50, Eric Dong wrote:
> This patch series include changes:
> 1. StartAllAPs should not use disabled APs, this is required by UEFI spec.
> 2. Refine the code to remove the redundant definitions.
> 
> V2 changes:
>   Use CpuStateReady to distinguish the AP state from CpuStateIdle.
> 
> V3 Changes:
>   Only change 3/3 patch. Only not use disabled APs when WakeUpAP called
> by StartAllAps function. In other cases, also include disabled APs.
> 
> Eric Dong (3):
>   UefiCpuPkg/MpInitLib: Remove redundant CpuStateFinished State.
>   UefiCpuPkg/MpInitLib: Remove StartCount and volatile definition.
>   UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs.
> 
>  UefiCpuPkg/Library/MpInitLib/MpLib.c | 33 +++++++++++++++------------------
>  UefiCpuPkg/Library/MpInitLib/MpLib.h |  4 +---
>  2 files changed, 16 insertions(+), 21 deletions(-)
> 

I requested commit message updates for all three patches. With those
implemented, please add:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

(No need to repost.)

Please give me some more time to regression-test this series as well.

Thanks!
Laszlo


  parent reply	other threads:[~2018-07-25 12:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25  7:50 [Patch V3 0/3] StartAllAPs should not use disabled APs Eric Dong
2018-07-25  7:50 ` [Patch v3 1/3] UefiCpuPkg/MpInitLib: Remove redundant CpuStateFinished State Eric Dong
2018-07-25 10:54   ` Laszlo Ersek
2018-07-25 11:15     ` Dong, Eric
2018-07-26  5:18       ` Ni, Ruiyu
2018-07-25  7:50 ` [Patch v3 2/3] UefiCpuPkg/MpInitLib: Remove StartCount and volatile definition Eric Dong
2018-07-25 11:47   ` Laszlo Ersek
2018-07-25 12:09     ` Dong, Eric
2018-07-25 15:18       ` Laszlo Ersek
2018-07-26  5:22   ` Ni, Ruiyu
2018-07-25  7:50 ` [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs Eric Dong
2018-07-25 12:11   ` Laszlo Ersek
2018-07-25 12:44     ` Dong, Eric
2018-07-26  8:36   ` Ni, Ruiyu
2018-07-26  8:36     ` Ni, Ruiyu
2018-07-25 12:12 ` Laszlo Ersek [this message]
2018-07-25 15:18   ` [Patch V3 0/3] StartAllAPs should not use disabled APs Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c47f474d-8dda-fd06-b7f1-5891b35cf5a1@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox