[RFC] Remove X86 .asm and .S assembly files in EDK2

[RFC] Remove X86 .asm and .S assembly files in EDK2

[Gao, Liming]

Edk2 has used nasm assembly file for all tool chains. So, IA32 and X64 .asm and .S assembly files can be removed if their nasm files are ready. It can save the maintain effort and avoid the confuse.



If you have any comments on this change, please let me know.

Thanks
Liming

Re: [RFC] Remove X86 .asm and .S assembly files in EDK2

[Laszlo Ersek]

On 01/31/18 12:06, Gao, Liming wrote:
> Edk2 has used nasm assembly file for all tool chains. So, IA32 and
> X64 .asm and .S assembly files can be removed if their nasm files are
> ready. It can save the maintain effort and avoid the confuse.
> 
> 
> 
> If you have any comments on this change, please let me know.

My comment is that I greatly welcome the removal of .S and .asm files :)

Thanks!
Laszlo

Re: [RFC] Remove X86 .asm and .S assembly files in EDK2

[Kinney, Michael D]

Liming,

After further evaluation on use of NASM with macho
there are a couple issues that need to be resolved
before the .asm and .S files can be removed from
all components.

The details are at:

https://bugzilla.tianocore.org/show_bug.cgi?id=881

NASM issues to be resolved are:

https://bugzilla.nasm.us/show_bug.cgi?id=3392469
https://bugzilla.nasm.us/show_bug.cgi?id=3392470

The recommendation is to not switch to NASM only
for libraries until the dead code stripping feature
works as expected on macho.

We can consider moving to NASM only for NASM files
in a module if there are no NASM functions that would
be dead stripped.  The recommendation for these types
of NASM files is do not use the following pragma
until the NASM issues above are resolved.

  %pragma macho subsections_via_symbols

Best regards,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Gao, Liming
> Sent: Wednesday, January 31, 2018 3:06 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [RFC] Remove X86 .asm and .S assembly
> files in EDK2
> 
> Edk2 has used nasm assembly file for all tool chains.
> So, IA32 and X64 .asm and .S assembly files can be
> removed if their nasm files are ready. It can save the
> maintain effort and avoid the confuse.
> 
> 
> 
> If you have any comments on this change, please let me
> know.
> 
> Thanks
> Liming
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [RFC] Remove X86 .asm and .S assembly files in EDK2

[Gao, Liming]

Mike:
  Now, %pragma macho subsections_via_symbols can't be enabled. So, will nasm generate the bigger image size than .S assembly on macho? If yes, I agree nasm is not same to .S. .S may be kept for a while. But, .asm is not necessary. We can remove .asm first. 

Thanks
Liming
> -----Original Message-----
> From: Kinney, Michael D
> Sent: Wednesday, March 14, 2018 4:00 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [RFC] Remove X86 .asm and .S assembly files in EDK2
> 
> Liming,
> 
> After further evaluation on use of NASM with macho
> there are a couple issues that need to be resolved
> before the .asm and .S files can be removed from
> all components.
> 
> The details are at:
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=881
> 
> NASM issues to be resolved are:
> 
> https://bugzilla.nasm.us/show_bug.cgi?id=3392469
> https://bugzilla.nasm.us/show_bug.cgi?id=3392470
> 
> The recommendation is to not switch to NASM only
> for libraries until the dead code stripping feature
> works as expected on macho.
> 
> We can consider moving to NASM only for NASM files
> in a module if there are no NASM functions that would
> be dead stripped.  The recommendation for these types
> of NASM files is do not use the following pragma
> until the NASM issues above are resolved.
> 
>   %pragma macho subsections_via_symbols
> 
> Best regards,
> 
> Mike
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-
> > bounces@lists.01.org] On Behalf Of Gao, Liming
> > Sent: Wednesday, January 31, 2018 3:06 AM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] [RFC] Remove X86 .asm and .S assembly
> > files in EDK2
> >
> > Edk2 has used nasm assembly file for all tool chains.
> > So, IA32 and X64 .asm and .S assembly files can be
> > removed if their nasm files are ready. It can save the
> > maintain effort and avoid the confuse.
> >
> >
> >
> > If you have any comments on this change, please let me
> > know.
> >
> > Thanks
> > Liming
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel

Re: [RFC] Remove X86 .asm and .S assembly files in EDK2

[Andrew Fish]

> On Mar 14, 2018, at 6:56 PM, Gao, Liming <liming.gao@intel.com> wrote:
> 
> Mike:
>  Now, %pragma macho subsections_via_symbols can't be enabled. So, will nasm generate the bigger image size than .S assembly on macho?

Yes. 

Thanks,

Andrew Fish

> If yes, I agree nasm is not same to .S. .S may be kept for a while. But, .asm is not necessary. We can remove .asm first. 
> 
> Thanks
> Liming
>> -----Original Message-----
>> From: Kinney, Michael D
>> Sent: Wednesday, March 14, 2018 4:00 AM
>> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: RE: [RFC] Remove X86 .asm and .S assembly files in EDK2
>> 
>> Liming,
>> 
>> After further evaluation on use of NASM with macho
>> there are a couple issues that need to be resolved
>> before the .asm and .S files can be removed from
>> all components.
>> 
>> The details are at:
>> 
>> https://bugzilla.tianocore.org/show_bug.cgi?id=881
>> 
>> NASM issues to be resolved are:
>> 
>> https://bugzilla.nasm.us/show_bug.cgi?id=3392469
>> https://bugzilla.nasm.us/show_bug.cgi?id=3392470
>> 
>> The recommendation is to not switch to NASM only
>> for libraries until the dead code stripping feature
>> works as expected on macho.
>> 
>> We can consider moving to NASM only for NASM files
>> in a module if there are no NASM functions that would
>> be dead stripped.  The recommendation for these types
>> of NASM files is do not use the following pragma
>> until the NASM issues above are resolved.
>> 
>>  %pragma macho subsections_via_symbols
>> 
>> Best regards,
>> 
>> Mike
>> 
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-
>>> bounces@lists.01.org] On Behalf Of Gao, Liming
>>> Sent: Wednesday, January 31, 2018 3:06 AM
>>> To: edk2-devel@lists.01.org
>>> Subject: [edk2] [RFC] Remove X86 .asm and .S assembly
>>> files in EDK2
>>> 
>>> Edk2 has used nasm assembly file for all tool chains.
>>> So, IA32 and X64 .asm and .S assembly files can be
>>> removed if their nasm files are ready. It can save the
>>> maintain effort and avoid the confuse.
>>> 
>>> 
>>> 
>>> If you have any comments on this change, please let me
>>> know.
>>> 
>>> Thanks
>>> Liming
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel