From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.59106.1629312320267411223 for ; Wed, 18 Aug 2021 11:45:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=Ya8W5mw9; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.0.0.19] (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id 685CC20C32C0; Wed, 18 Aug 2021 11:45:19 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 685CC20C32C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1629312319; bh=45bMWWPDt0PU0HpKJnUqL3VN+l6WUNpPS2cNJvRJtps=; h=Subject:From:To:Reply-To:References:Date:In-Reply-To:From; b=Ya8W5mw9E6AHCT+VDfc8wfet5vy2P6KhLd8nHGBKG/5RZdHhmWa1qi5piLfHi4Pgg neAd7Xu0nB43zYFrP0sAkRQbrlXWHoPS4ZxgllJBbIQlNYWwN802G5YZxKKDaFDKCY fe1b9lxGxBkOQcx+IgZHAACdC2WesZJbDh0n8rak= Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull From: "Michael Kubacki" To: Ray , devel@edk2.groups.io Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <28423.1628820964257783330@groups.io> Message-ID: Date: Wed, 18 Aug 2021 14:45:18 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <28423.1628820964257783330@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ray, It's been a while. This change is really not that complicated. Can it be merged if there are no substantial opens? Regards, Michael On 8/12/2021 10:16 PM, Michael Kubacki wrote: > Sure. > > Scenario #1: > > MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf and > MinPlatormPkg/PlatformInit/PlatformInitPei/PlatformInitPostMem.inf both > link against an instance of BoardInitLib. > > Many boards link against a single BoardInitLib instance. See example - > https://github.com/tianocore/edk2-platforms/blob/cd4e6b716c7d1bcde94035e7dce14b53a553e103/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc#L203 > > That BoardInitLib instance may link against SmmAccessLib. > PlatformInitPreMem may wish to library class override the SmmAccessLib > to the NULL instance while keeping it to non-NULL instance in > PlatformInitPostMem. > > Scenario #2: > > A PEIM is built that checks whether the boot mode is S3. If so, it calls > PeiInstallSmmAccessPpi(). A particular platform does not support S3, > therefore, it links BaseSmmAccessLibNull as its library instance for > SmmAccessLib. >