Re: [Patch 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.

["Laszlo Ersek" <lersek@redhat.com>]

On 02/10/20 11:58, Siyuan Fu wrote:
> Commit c7c964b and dd01704 add header file for FIT table and update
> MpInitLib to support FIT based microcode shadow operation. There are
> comments that FIT is Intel specific specification instead of industry
> standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg.
> So this patch adds a platform PPI for the microcode shadow logic, and
> remove the FIT related code from EDK2.
> The FIT based microcode shadow support will be implemented as a new
> platform PEIM in IntelSiliconPkg in edk2-platforms.
> 
> A detailed design doc can be found here:
> https://edk2.groups.io/g/devel/files/Designs/2020/0214/Support%20
> the%202nd%20Microcode%20FV%20Flash%20Region.pdf
> 
> TEST: Tested on FIT enabled platform.
> BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> ---
>  UefiCpuPkg/Include/Ppi/ShadowMicrocode.h      |  66 +++++++++++
>  UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf |   1 -
>  UefiCpuPkg/Library/MpInitLib/DxeMpLib.c       |  21 +++-
>  UefiCpuPkg/Library/MpInitLib/Microcode.c      | 105 +-----------------
>  UefiCpuPkg/Library/MpInitLib/MpLib.h          |  19 +++-
>  UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf |   4 +-
>  UefiCpuPkg/Library/MpInitLib/PeiMpLib.c       |  70 +++++++++++-
>  UefiCpuPkg/UefiCpuPkg.dec                     |  11 +-
>  8 files changed, 179 insertions(+), 118 deletions(-)
>  create mode 100644 UefiCpuPkg/Include/Ppi/ShadowMicrocode.h

(1) Please don't forget to update "UefiCpuPkg/UefiCpuPkg.uni" as well.

With that addressed:

Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo