From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.23982.1581350096234448366 for ; Mon, 10 Feb 2020 07:54:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fBLvTCYR; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581350095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ScIoO48/0BMSCzWr8EXoXjo3DkT7YjG84rHczkM2eRQ=; b=fBLvTCYR4u3+dYN9g002+wcjPaymtw0W/txsBRRuAGNPgKK63/bUuU4fHeVhyvlT1B5AZr Ev8b/FhJS2zzWa7Cme/hTh2fmjeb/ZHzdWTkNQyfnUgK7C/7z9CD4FM3W5EqpGC2RSmhAj dq33mYWQH+OtVBlFSF5m7xzWKRdL7k0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-3FHnQCLiOZW_zvP1H6vxQw-1; Mon, 10 Feb 2020 10:54:37 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2345F18A8C8A; Mon, 10 Feb 2020 15:54:36 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E05382063; Mon, 10 Feb 2020 15:54:34 +0000 (UTC) Subject: Re: [Patch 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib. To: Siyuan Fu , devel@edk2.groups.io Cc: Eric Dong , Ray Ni References: <20200210105849.30472-1-siyuan.fu@intel.com> <20200210105849.30472-2-siyuan.fu@intel.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 10 Feb 2020 16:54:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200210105849.30472-2-siyuan.fu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: 3FHnQCLiOZW_zvP1H6vxQw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/10/20 11:58, Siyuan Fu wrote: > Commit c7c964b and dd01704 add header file for FIT table and update > MpInitLib to support FIT based microcode shadow operation. There are > comments that FIT is Intel specific specification instead of industry > standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg. > So this patch adds a platform PPI for the microcode shadow logic, and > remove the FIT related code from EDK2. > The FIT based microcode shadow support will be implemented as a new > platform PEIM in IntelSiliconPkg in edk2-platforms. > > A detailed design doc can be found here: > https://edk2.groups.io/g/devel/files/Designs/2020/0214/Support%20 > the%202nd%20Microcode%20FV%20Flash%20Region.pdf > > TEST: Tested on FIT enabled platform. > BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449 > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Siyuan Fu > --- > UefiCpuPkg/Include/Ppi/ShadowMicrocode.h | 66 +++++++++++ > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 - > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 21 +++- > UefiCpuPkg/Library/MpInitLib/Microcode.c | 105 +----------------- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 19 +++- > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 4 +- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 70 +++++++++++- > UefiCpuPkg/UefiCpuPkg.dec | 11 +- > 8 files changed, 179 insertions(+), 118 deletions(-) > create mode 100644 UefiCpuPkg/Include/Ppi/ShadowMicrocode.h (1) Please don't forget to update "UefiCpuPkg/UefiCpuPkg.uni" as well. With that addressed: Acked-by: Laszlo Ersek Thanks Laszlo