From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mx.groups.io with SMTP id smtpd.web12.1409.1642532415303370788 for ; Tue, 18 Jan 2022 11:00:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Q6OXynyy; spf=pass (domain: gmail.com, ip: 209.85.214.180, mailfrom: kuqin12@gmail.com) Received: by mail-pl1-f180.google.com with SMTP id u11so20105098plh.13 for ; Tue, 18 Jan 2022 11:00:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=t4J+LPyq5TxXY1nB0WnTkSbYr6DLFqbm2LCEXRlsut0=; b=Q6OXynyyozJtQpenGk95Ybz+FvsHFnJFpKG1O26ZI6cPQuYhusLQMCw4A4nY0jXOPE JwiX5j9iWH8I0ZpfaA/5W4coUKUpg45pahSdW2+jSFDxGxGu7b0Hhnm7pKDJ2HrW0ina pP5t5vi1IbDaSioUtraufmctioyriSlC+JK8QdaC+bHXmF8XUeefDh8kpwaKh+5rVHK3 0DWfVTZDFmTpDpENqcinJpwYs5e/ZUW7/pLoMb5CntU9RBRG6E4StY6CXdqCDXTOe8VW Frcz+9vgOdlYI8iZc411EBgu6L95tzP2n0UGGH6r6v9NP8BGU5Gs6xpB9f7f6Wqb3pBr LyVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=t4J+LPyq5TxXY1nB0WnTkSbYr6DLFqbm2LCEXRlsut0=; b=lEYHAGCudFCwi8w43dGwoQNEYp8Qnd/66x19vx5GS2NhK4C2aS9j7r9WqgXzQIluoX jJgha7ZGdXv1Gixej/IAHFaIbUpZ9hYT6bq8K5cvDWtDbR6T4OPEWSZYTptVctz/sDmd zo0/3tpxxymAzvQJIblAW7WF25V70FWbr30UdywDEXt5fcSXT/5U6hISwv8mMy+8Bk70 hMiIGAy3zii9HwvGopTaBxigdrBAKVXDBLmAiPQkszm5QOTFzY+eQbq8kWodxWj7Ojoh ux8EIAjEUkJ7GCrTDEwkjJSA9p3+jT4bw7nvPFteKissCvMuHIeUxBvAI+bajFEmQoiF HPbA== X-Gm-Message-State: AOAM531sTa9xBJ6v4CD80LBCIXjANNR4fkSIbZVAoqZtrn0J1xh/Au3q p65mXcRNLUwCiyAfY8HXwx9W/8S5yp8= X-Google-Smtp-Source: ABdhPJxB+uFFiI2vp7D8rFi/WCJISPDqnA49p1RIF96joKJDZ0RlYzghY4Js2BZwx8vCrcgkYT3uWw== X-Received: by 2002:a17:90b:1e07:: with SMTP id pg7mr23859573pjb.94.1642532414614; Tue, 18 Jan 2022 11:00:14 -0800 (PST) Return-Path: Received: from [192.168.1.18] ([50.35.74.198]) by smtp.gmail.com with ESMTPSA id 25sm3473863pje.22.2022.01.18.11.00.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jan 2022 11:00:14 -0800 (PST) Message-ID: Date: Tue, 18 Jan 2022 11:00:14 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [edk2-devel] [PATCH v2 1/2] EDK2 Code First: PI Specification: New error codes of Host Software class To: devel@edk2.groups.io, Michael D Kinney Cc: Andrew Fish , Leif Lindholm , Liming Gao , Zhiguang Liu References: <20220108013242.2030-1-kuqin12@gmail.com> <16C82792D4F086F3.710@groups.io> From: "Kun Qin" In-Reply-To: <16C82792D4F086F3.710@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Mike, Do you have further feedback regarding this updated change? If not, could you please shed some light on how to proceed on this code first PI spec change request? Any help is appreciated. Regards, Kun On 01/07/2022 17:32, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794 > > This change includes specification update markdown file that describes > the proposed PI Specification v1.7 Errata A in detail and potential > impact to the existing codebase. > > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > > Signed-off-by: Kun Qin > --- > > Notes: > v2: > - Removed "RELEASE_ASSERT" definition > - Removed reference to EDK2 based memory type info [Mike] > > CodeFirst/BZ3794-SpecChange.md | 55 ++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/CodeFirst/BZ3794-SpecChange.md b/CodeFirst/BZ3794-SpecChange.md > new file mode 100644 > index 000000000000..61a0be798d7f > --- /dev/null > +++ b/CodeFirst/BZ3794-SpecChange.md > @@ -0,0 +1,55 @@ > +# Title: Introduction of `EFI_SW_EC_FRAGMENTED_MEMORY_MAP` Status Code > + > +## Status: Draft > + > +## Document: UEFI Platform Initialization Specification Version 1.7 Errata A > + > +## License > + > +SPDX-License-Identifier: CC-BY-4.0 > + > +## Submitter: [TianoCore Community](https://www.tianocore.org) > + > +## Summary of the change > + > +Add `EFI_SW_EC_FRAGMENTED_MEMORY_MAP` into Status Codes definition. > + > +## Benefits of the change > + > +Current Status Codes covered various [software class error code definitions](https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Pi/PiStatusCode.h). > + > +However, fragmented memory map from boot to boot would fail to meet certain OS ACPI requirements (i.e. S4 resume boot requires consistent memory maps) and trigger system reboots. Yet the corresponding case was not covered by the already defined status codes. > + > +The unexpected system reboots above could indicate decay of system health and reporting of such generic events would provide helpful information to OEMs to investigate/prevent system failures in general. > + > +The request of this change intends to expand definitions of `EFI_SW_EC_**` under Status Codes to cover more unexpected system reboot events, which could improve Status Code futility and readability. > + > +## Impact of the change > + > +Occupy a new macro definitions of Error Codes under Software class Status Codes. > + > +## Detailed description of the change [normative updates] > + > +### Specification Changes > + > +1. In PI Specification v1.7 Errata A: Vol. 3, Table 3-61: Error Code Operations: Host Software Class, add one new rows below `EFI_SW_EC_FV_CORRUPTED` definition: > + > + | Operation | Description | Extended Data | > + | --- | --- | --- | > + | EFI_SW_EC_FRAGMENTED_MEMORY_MAP | System will reboot due to fragmented memory maps | None | > + > +1. In PI Specification v1.7 Errata A: Vol. 3, Table 3-61: Error Code Operations: Host Software Class, replace the row of `0x0014-0x00FF` to: > + > + | Operation | Description | Extended Data | > + | --- | --- | --- | > + | 0x0015-0x00FF | Reserved for future use by this specification for Host Software class error codes. | None | > + > +1. In PI Specification v1.7 Errata A: Vol. 3, Section 6.7.4.3 Error Code Definitions: Prototype, add one new definitions below `EFI_SW_EC_FV_CORRUPTED` definition: > + > + ```c > + #define EFI_SW_EC_FRAGMENTED_MEMORY_MAP 0x00000014 > + ``` > + > +### Code Changes > + > +1. Add macro definitions in `MdePkg/Include/Pi/PiStatusCode.h` to match new specification.