From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.66, mailfrom: philmd@redhat.com)
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66])
 by groups.io with SMTP; Wed, 24 Jul 2019 05:21:39 -0700
Received: by mail-wr1-f66.google.com with SMTP id n4so46833129wrs.3
        for <devel@edk2.groups.io>; Wed, 24 Jul 2019 05:21:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:openpgp:message-id
         :date:user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=3uXXMgc5NLk+7dz7S+tedTqyz10TNWgT1pqTaMP0qp4=;
        b=PI6Qu+A9WLdheFIa1lNrJqgmp9cu6kQDC9OsPfLZkmwKcoBvyYvGmWIRFOd6bEFig/
         oIYPfM/tGhq/FUCjSjt0Z4UQT56Cr4ghjlgrk1jNtiVMp5pxxVsZSYQoHUndrTeL+jMu
         QY9NuUtd5A6OlapgDkJLRqx0UHCsLNs9/1/k6LO0HeAUzltxR5IMJQtFzEmzy7s/Pq0H
         Z50LRjsegKxeEuWHEY9RJBGoX5wzgaBPn71eFpAOTbfUZrxPz81eLxXA69rZpRJ06lUC
         3kC2laVQ8SEsARQoafcjD7F6nCivBo/4ZLYDBTUmROLCrCIrX+H5qj+5jRlA62zZrEMP
         +ycw==
X-Gm-Message-State: APjAAAVfql5HEykcKGLzKTkaOeEvd8uLfrLI7+08l87R1dZqo8cc7cap
	ZmZuqw328bcEMRJi0R/GfHhUIw==
X-Google-Smtp-Source: APXvYqxksSMxekwfHCjZ5X8J+UzfmpRbJb7aJqT7lCFh5G8YgRlw/JvgikAxKFJUuf644BOXZoeTYg==
X-Received: by 2002:a5d:6508:: with SMTP id x8mr61082307wru.310.1563970897584;
        Wed, 24 Jul 2019 05:21:37 -0700 (PDT)
Return-Path: <philmd@redhat.com>
Received: from [10.201.33.105] ([195.166.127.210])
        by smtp.gmail.com with ESMTPSA id k17sm52330202wrq.83.2019.07.24.05.21.36
        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);
        Wed, 24 Jul 2019 05:21:36 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
To: devel@edk2.groups.io, rebecca@bsdio.com,
 Jordan Justen <jordan.l.justen@intel.com>, Laszlo Ersek <lersek@redhat.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190723003225.46171-1-rebecca@bsdio.com>
From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= <philmd@redhat.com>
Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE;
 url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
Message-ID: <c4f23e70-ee47-b576-6b9c-7b2defee3041@redhat.com>
Date: Wed, 24 Jul 2019 14:21:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190723003225.46171-1-rebecca@bsdio.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 7/23/19 2:32 AM, rebecca@bsdio.com wrote:
> Enable multithreaded builds by default when building OvmfPkg
> using build.sh.
> This can drastically reduce build times. For example, on a
> modern ThreadRipper system the time required to build decreases
> from 3 minutes to 1 minute.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 4fcbdd2bc9..bacab5e22a 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -40,7 +40,7 @@ ARCH_X64=no
>  BUILDTARGET=DEBUG
>  BUILD_OPTIONS=
>  PLATFORMFILE=
> -THREADNUMBER=1
> +THREADNUMBER=0
>  LAST_ARG=
>  RUN_QEMU=no
>  ENABLE_FLASH=no
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>