From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6BB5A74003D for ; Tue, 7 Nov 2023 13:11:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2aq7HmTR3NEqp7F7mJafeq7QymQavxlk+oNTV1NlaSg=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699362679; v=1; b=oymIPcQcsDUm4NlzbHnYlm0ujlPdyCxAWdqn7L7zodAby2SEL7sg11+njIHsBgL0psNq/xSx LKwBInE4EQC4rUOTtk62BRgIKGcxDwFJ4uNmfy/fsHhMSjfSM6/gRMDvQUGs0LkBQOREAoYjXOV kHG8W+SIvDjvKnkQFRnPUkVs= X-Received: by 127.0.0.2 with SMTP id mrjlYY7687511xUactsPN6Zm; Tue, 07 Nov 2023 05:11:19 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.9933.1699362678647741209 for ; Tue, 07 Nov 2023 05:11:18 -0800 X-Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A7ABa4C032514; Tue, 7 Nov 2023 13:11:03 GMT X-Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u72c02mvt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Nov 2023 13:11:02 +0000 X-Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3A7DB2Ul029755 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 Nov 2023 13:11:02 GMT X-Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Tue, 7 Nov 2023 05:11:01 -0800 X-Received: from nalasex01a.na.qualcomm.com ([fe80::2767:b893:469e:ca24]) by nalasex01a.na.qualcomm.com ([fe80::2767:b893:469e:ca24%4]) with mapi id 15.02.1118.039; Tue, 7 Nov 2023 05:11:01 -0800 From: "Yeping Song" To: "devel@edk2.groups.io" , "Yeping Song (QUIC)" , Liming Gao , "Leif Lindholm (QUIC)" CC: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , "Ard Biesheuvel" , "Leif Lindholm (QUIC)" , Sami Mujawar , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF Thread-Index: AQHaDncf+E4UIcqc5kqz2K1PTlvzgbBvYOBQ Date: Tue, 7 Nov 2023 13:11:01 +0000 Message-ID: References: <17942B788A4667A6.3650@groups.io> In-Reply-To: <17942B788A4667A6.3650@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.253.38.198] MIME-Version: 1.0 X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: QNrLdsbVe8IgpOriGQJg995-uIqqr5vr X-Proofpoint-GUID: QNrLdsbVe8IgpOriGQJg995-uIqqr5vr Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_yepings@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: SzBt1JYXrHqPI7ZDVBrV1WGnx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oymIPcQc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi all, I would like for this to be include in stable tag. Please help to review an= d merge this patch into stable release. Thanks Yepings -----Original Message----- From: devel@edk2.groups.io On Behalf Of Yeping Song Sent: Saturday, November 4, 2023 12:38 AM To: devel@edk2.groups.io Cc: Yeping Song (QUIC) ; Rebecca Cran ; Liming Gao ; Bob Feng ; Yuwei Chen ; Ard Biesheuvel ; Leif Lindholm (QUIC) ; Sami Mujawar <= sami.mujawar@arm.com> Subject: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-= only for AArch64 CLANGDWARF WARNING: This email originated from outside of Qualcomm. Please be wary of = any links or attachments, and do not enable macros. Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64: avoid SIMD registers in XIP code") adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, in order to avoid a bu= g present in certain versions of GCC. This was never a problem for clang. That's given the history of what the problem is. Then we can describe how we fix it: Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required -mstrict-align = option instead of importing the whole GCC variable. Signed-off-by: Yeping Song Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.t= emplate index 5bd5283655ea..c34ecfd557c5 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS =3D DEF(CLANGD= WARF_AARCH64_TARGET) DEF(GCC_ *_CLANGDWARF_AARCH64_RC_FLAGS =3D DEF(GCC_AARCH64_RC_FLAGS) DEF(GCC_= AARCH64_RC_BTI_FLAGS) *_CLANGDWARF_AARCH64_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) DEF(CLANGDWAR= F_AARCH64_TARGET) $(PLATFORM_FLAGS) *_CLANGDWARF_AARCH64_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) DEF(CLANGDWAR= F_AARCH64_TARGET) -*_CLANGDWARF_AARCH64_CC_XIPFLAGS =3D DEF(GCC_AARCH64_CC_XIPFLAGS) +*_CLANGDWARF_AARCH64_CC_XIPFLAGS =3D -mstrict-align DEBUG_CLANGDWARF_AARCH64_CC_FLAGS =3D DEF(CLANGDWARF_AARCH64_CC_FLAGS= ) $(PLATFORM_FLAGS) -flto -O1 DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS =3D DEF(CLANGDWARF_AARCH64_DLINK_FL= AGS) -flto -Wl,-O1 -fuse-ld=3Dlld -L$(WORKSPACE)/ArmPkg/Library/GccLto -llt= o-aarch64 -Wl,-plugin-opt=3D-pass-through=3D-llto-aarch64 -Wl,--no-pie,--no= -relax -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110851): https://edk2.groups.io/g/devel/message/110851 Mute This Topic: https://groups.io/mt/102368361/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-