From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web11.10996.1598960793930690086 for ; Tue, 01 Sep 2020 04:46:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=A1NcJDmZ; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.67, mailfrom: pete@akeo.ie) Received: by mail-wr1-f67.google.com with SMTP id c15so1148189wrs.11 for ; Tue, 01 Sep 2020 04:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=T0w84cLPcew0tx7wIRFWgIgNLFbxBcqKjQEPj70WFZU=; b=A1NcJDmZX029KWYeDWLx4fTEs1j8H62CLBQ0AUCSqUsSrbmg4cjAQxtccXkSLP6/0K zTELGKAuJe/5SkJIy04ifFP75Tf8mDMwuyrm3R/nbbqwwqSuQCw0OkGd5LnC1Ns+KSct 3sKIeWs0Y6eO0b0vM1Hz2ah2/bJiAcWrBLyTVe1x68nYxVsWmNBTet8M56mdDXyIxpai WXATkXjzBv4nlWe1PW1G5Y1z0UInR4WMuUbXgus1syS6ZlPUDJAojAQLBoLluVOvVSGk MW/aLyPo/5rN7QfaRIbRQ5SSVbfEoTFHL/y1iIphUGcX5GqiFaA+L5K/9eJDNWidjHX2 qfXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T0w84cLPcew0tx7wIRFWgIgNLFbxBcqKjQEPj70WFZU=; b=Mr+s0U/HNFozqk4Pqxkg6l+sY8PR7JV4xfN7PrnalSbTUMHZaKYVdo5q0iJupftcKX zDpRvb5V0xyA0N0ZIogNYQKj0J5BYj7Bp2Q1CdCsSE0u9mvJ2xEuHb2bNXwBjLY9qxUT tPwhS3nnN/IuzlrGA09Fh8JaS+tv39GMZz5tLM671T02vp9+0hCvO8/1lZXcBlZ+3Bz+ QARIiCwUs+hZrUnujU4wrTAANxMuXY99WHMCaZZRyj09WtyPHgltRbaZOVE8aELYOSPo mrQ3LD5o9S87CwHTf5fjcJJAIpguvNIBu2jbXqLRMqRW/GX0vIcCBYUnwbXuCk59kUAU 9cSg== X-Gm-Message-State: AOAM5323qChLsD5MIoNKxWvkhvdac8ndLQFXyx044dEnerLzLeKbbmf8 lr4DQaBXwXVpSRp0Ms/QER5v3A== X-Google-Smtp-Source: ABdhPJzMq65Y9DICad08y0Te3zfT7KnkTtOEd514PF3a2jhtuDPt1LLEVPuwfqUY7casuoXA2jXyWA== X-Received: by 2002:a05:6000:110b:: with SMTP id z11mr1514162wrw.426.1598960792379; Tue, 01 Sep 2020 04:46:32 -0700 (PDT) Return-Path: Received: from [10.0.0.130] ([84.203.85.10]) by smtp.googlemail.com with ESMTPSA id j10sm1902533wrn.2.2020.09.01.04.46.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 04:46:31 -0700 (PDT) Subject: Re: [PATCH v4 6/6] Platform/RaspberryPi: Trivial whitespace cleanup To: Ard Biesheuvel , Jeremy Linton , devel@edk2.groups.io Cc: Leif Lindholm , Andrei Warkentin , Samer El-Haj-Mahmoud References: <20200831172549.24079-1-jeremy.linton@arm.com> <20200831172549.24079-7-jeremy.linton@arm.com> <7d6c81cb-8d2e-2991-d585-300df9f00a13@arm.com> From: "Pete Batard" Message-ID: Date: Tue, 1 Sep 2020 12:46:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <7d6c81cb-8d2e-2991-d585-300df9f00a13@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Ard, On 2020.09.01 12:39, Ard Biesheuvel wrote: > On 8/31/20 7:25 PM, Jeremy Linton wrote: >> Pete's review pointed out some whitespace issues in the >> context of a previous patch. Since there are a number of >> similar errors in the file lets fix them separately. >> >> Cc: Leif Lindholm >> Cc: Pete Batard >> Cc: Andrei Warkentin >> Cc: Ard Biesheuvel >> Cc: Samer El-Haj-Mahmoud >> Signed-off-by: Jeremy Linton >> Reviewed-by: Pete Batard <@pbatard> >> --- >>   Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 24 >> +++++++++++----------- >>   1 file changed, 12 insertions(+), 12 deletions(-) >> >> diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c >> b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c >> index e8f964a329..4ed294cdfe 100644 >> --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c >> +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c >> @@ -209,9 +209,9 @@ SetupVariables ( >>     } >>     Size = sizeof (UINT32); >> -  Status = gRT->GetVariable(L"CustomCpuClock", >> -                            &gConfigDxeFormSetGuid, >> -                            NULL, &Size, &Var32); >> +  Status = gRT->GetVariable (L"CustomCpuClock", >> +                             &gConfigDxeFormSetGuid, >> +                             NULL, &Size, &Var32); >>     if (EFI_ERROR (Status)) { >>       Status = PcdSet32S (PcdCustomCpuClock, PcdGet32 >> (PcdCustomCpuClock)); >>       ASSERT_EFI_ERROR (Status); >> @@ -266,7 +266,7 @@ SetupVariables ( >>     Size = sizeof (AssetTagVar); >> -  Status = gRT->GetVariable(L"AssetTag", >> +  Status = gRT->GetVariable (L"AssetTag", >>                     &gConfigDxeFormSetGuid, >>                     NULL, &Size, AssetTagVar); >> @@ -275,7 +275,7 @@ SetupVariables ( >>                       L"AssetTag", >>                       &gConfigDxeFormSetGuid, >>                       EFI_VARIABLE_NON_VOLATILE | >> EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, >> -                    sizeof(AssetTagVar), >> +                    sizeof (AssetTagVar), >>                       AssetTagVar >>                       ); >>     } >> @@ -441,9 +441,9 @@ ApplyVariables ( >>        * spaces. SystemMemorySizeBelow4GB tracks the maximum memory >> below 4GB >>        * line, factoring in the limit imposed by the SoC register range. >>        */ >> -    SystemMemorySizeBelow4GB = MIN(SystemMemorySize, 4UL * SIZE_1GB); >> -    SystemMemorySizeBelow4GB = MIN(SystemMemorySizeBelow4GB, >> BCM2836_SOC_REGISTERS); >> -    SystemMemorySizeBelow4GB = MIN(SystemMemorySizeBelow4GB, >> BCM2711_SOC_REGISTERS); >> +    SystemMemorySizeBelow4GB = MIN (SystemMemorySize, 4UL * SIZE_1GB); >> +    SystemMemorySizeBelow4GB = MIN (SystemMemorySizeBelow4GB, >> BCM2836_SOC_REGISTERS); >> +    SystemMemorySizeBelow4GB = MIN (SystemMemorySizeBelow4GB, >> BCM2711_SOC_REGISTERS); >>       ASSERT (SystemMemorySizeBelow4GB > 3UL * SIZE_1GB); >> @@ -536,14 +536,14 @@ ApplyVariables ( >>         /* >>          * SD card pins go to Arasan. >>          */ >> -      MmioWrite32((GPIO_BASE_ADDRESS + 0xD0), >> -                  MmioRead32(GPIO_BASE_ADDRESS + 0xD0) | 0x2); >> +      MmioWrite32 ((GPIO_BASE_ADDRESS + 0xD0), >> +                  MmioRead32 (GPIO_BASE_ADDRESS + 0xD0) | 0x2); >>       } else { >>         /* >>          * SD card pins back to eMMC2. >>          */ >> -      MmioWrite32((GPIO_BASE_ADDRESS + 0xD0), >> -                  MmioRead32(GPIO_BASE_ADDRESS + 0xD0) & ~0x2); >> +      MmioWrite32 ((GPIO_BASE_ADDRESS + 0xD0), >> +                  MmioRead32 (GPIO_BASE_ADDRESS + 0xD0) & ~0x2); > > Anyone mind if I replace these with MmioOr32 / MmioAnd32 ? No objection from me. This should indeed make the code cleaner. Thanks, /Pete > > >>         /* >>          * WiFi back to Arasan. >>          */ >> >